Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32 Sound output stopped working with IDF >= 4.2.0 #627

Open
judge2005 opened this issue May 16, 2023 · 1 comment
Open

ESP32 Sound output stopped working with IDF >= 4.2.0 #627

judge2005 opened this issue May 16, 2023 · 1 comment

Comments

@judge2005
Copy link
Contributor

There were quit a few changes around the use of mclk in the Espressif IDE. My hardware doesn't use that signal and to get the code working again I had to call SetMclk(false) on the instance of AudioOutputI2S. There are some comments in the source code to the effect that 'mclk' isn't used, but this isn't the case if use_mclk is true. I don't know what the default for that flag should be, except maybe to be backwards-compatible it should default to false.

@lyusupov
Copy link

I can confirm that PR #552 broke ESP32 EXT no-mclk I2S function in past and this PR gives a positive fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants