-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can't select "hand with fingers splayed" emoji in any skin colour other than Neutral #367
Comments
This is very peculiar. Thank you for reporting this, @arjita-mitra. Can confirm I am seeing this behavior on my end too. I'll have to dig into it. |
OK. this is indeed weird. Wound the reason, and the reason is that the emoji is non-standard, as in - unlike most (but not all!) hand emojis, it does not have a "neutral" skin tone in the specification, and as such, its unified code is different between the neutral mode and the rest. I'll have to see what to do about that. Might take a few days to sort out. Source:
|
thank you for debugging this. I will be waiting for the fix :-) |
@arjita-mitra I think this is now solved in emoji-picker-react@4.5.7, please let me know if that works for you as well. |
Thank you so much for fixing this so quickly. Really appreciate this :-) I have verified that the emoji can be selected and hovered correctly now, only issue is that I am not getting the correct unicode skin modifier combination. For example-
As you can see the emoji object property "v" doesn't contain the full unicode "1f590-fe0f-1f3fb" instead "1f590-1f3fb". so far all the "v" property has the complete unicode given in "u" property + the skin tone modifier so the following code to extract the emoji title always worked for me. I store all the emojis by their unicode comes as part of "u" prop then I check for skin tome modifiers in the unicode and remove them if required and extract the title based on the unicode without skintone modifiers. Since this emoji is missing fe0f part of the unicode so the title is not getting extracted correctly. I couldn't reproduce it for any other emoji so far. Let me know you can do anything about this.
|
I have found a bug with a particular emoji- "hand with fingers splayed". I have tested it in your live demo too and the issue is present there.
As you can see in the screenshot I have hovered and tried to select the hand with fingers splayed emoji but its not getting selected and the emoji details in the modal footer is also wrong its the default emoji I guess. I tried to log the emojidata to see whats wrong, surprisingly the click event is not even triggered so nothing got logged inside the onClick handler. Last thing I verified is this emoji object is present in the emoji.json file like every other emojis.
In the screenshot below I have the same emoji hovered but in neutral skin tone, this is working.
Please fix this issue as its a major bug and we are using this in production.
The text was updated successfully, but these errors were encountered: