-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange performance difference between xmldiff:compare() and deep-equal() #4050
Comments
AFAIK for |
I have recently played around with |
@dizzzz @adamretter I just heard that there are plans to ditch xmldiff:compare. I'd really hope for this issue to be looked into before this is effectuated. |
@PieterLamers I don't think we would intentionally remove it if there is not a good replacement. However, please remind me as we prepare eXist 7, so we don't remove it by accident as part of our tech debt cleanup |
@PieterLamers So we definitely are not removing xmldiff:compare - as we just added a new implementation of it here - #4554 |
@xatapult I reran your tests on my laptop:
It looks like we would still need to optimise |
Describe the bug
We have tried to do XML compares using
xmldiff:compare()
and the XPath equivalentdeep-equal()
.For comparing two equal documents of ~200Kb
xmldiff:compare()
on my machine taks 60msecs,deep-equal()
over 9 seconds!Expected behavior
The functions vary slightly in interface, but just comparing two documents should roughly take the same amount of time. And if not 9 seconds is a bit too much I think.
To Reproduce
Unzip, import in eXist, execute
test-equals.xql
(I'm doing this from oXygen)Context (please always complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: