Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs with wrong title and not updating for large files [BUG] #429

Open
lguariento opened this issue Feb 16, 2022 · 9 comments
Open

Tabs with wrong title and not updating for large files [BUG] #429

lguariento opened this issue Feb 16, 2022 · 9 comments

Comments

@lguariento
Copy link
Contributor

Having a large file opened in eXide, alongside with others, and working on it for long sessions, generates some unexpected behaviour whereby the title of the tab of the large file gets replaced with the title of an adjacent tab, so that one ends up with two tabs with the same title. The file is still there though. Also, the 'selected' class is not applied correctly when this happens.

The values in the LocalStorage seems to be correct.

A file which triggers the error can be downloaded here. It's the BOSLIT_dataset.xml inside the .zip.

@joewiz
Copy link
Member

joewiz commented Feb 16, 2022

I've seen such a thing intermittently too. Have you been able to develop a set of specific steps to reproduce this with your file?

@lguariento
Copy link
Contributor Author

I've been trying to get specific steps and failed so far. The closest thing I've come to so far is when I leave the computer for a couple of hours, with the open browser on eXide. When I come back the issue, which wasn't there before, is there.

@lguariento
Copy link
Contributor Author

lguariento commented Feb 17, 2022

One thing I was just thinking of: is it possible to have eXide to refuse to open the same document more than once? Sometimes I click on the same file more than once, either because I am not sure the first click was registered (as larger files take longer to open and eXide doesn't give any clue about if it's in the process of opening a file), or because I just forget I already opened that file :) , or by mistake. This might be related, and indeed it has happened that I opened multiple instances of the large file we are discussing here (although I have closed the duplicates afterwards). I don't know eXide's framework; since the variables get stored in LocalStorage something as simple as if target in array.LocalStorage then don't do anything (or even better focus on the already-opened tab) would do.

@joewiz
Copy link
Member

joewiz commented Feb 17, 2022

I've also seen this (and have not been able to find a reproducible test). It's definitely a bug. If we can find some way to induce eXide to open the same document in 2 tabs, maybe we can get to the bottom of it. I suspect the issues may be related.

@lguariento
Copy link
Contributor Author

It always opens the same document in different multiple tabs when clicking on it for me, I thought it was the standard behaviour, hence my previous message.

Screenshot 2022-02-17 at 15-13-47 eXide

@joewiz
Copy link
Member

joewiz commented Feb 17, 2022

Ah, I didn't realize this happens for you always and not just sometimes. That's quite promising! ;) Could you list detailed steps to reproduce? There are multiple ways to open documents in eXide, so please specify which method.

@lguariento
Copy link
Contributor Author

lguariento commented Feb 17, 2022

From the 'directory' tab on the left, click on a document, then click on it again, then again.... repeat :)

Edit: I notice now that it happens only while eXide is still (silently) loading the document you've clicked on. So, click on a large document. You don't get any feedback, so before the large document is open, you click again on the document in the 'directory' tab. Eventually, after a minute or so, eXide will start opening the same document in as many tabs as many times you've clicked on it.

@joewiz
Copy link
Member

joewiz commented Feb 17, 2022

Ah, ok, that makes sense. I wouldn't know how to go about fixing this. But it sounds like you have a possible javascript route in mind?

@lguariento
Copy link
Contributor Author

lguariento commented Feb 17, 2022

I'm happy to look into it if someone can guide me on the inner workings of eXide. From my ignorant standpoint I think a simple check on the click event should do the trick. So, whenever a document is clicked, store something in the LocalStorage. When you click on its document again, check if that document is already in the queue. If it is, ignore the click (or give some feedback like 'already opening' or something like that).

Incidentally I just checked my console and I see that now nothing is logged in my LocalStorage when opening / closing new tabs. Yesterday I was having data there. I'm not sure what's going on with eXide lately, it's being temperamental.

Screenshot 2022-02-17 at 17 55 37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants