Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebay-calendar, ebay-date-textbox: add docs and story for disabled textbox with disabled icon #2284

Closed
pranaykondekar opened this issue Mar 8, 2024 · 3 comments
Assignees
Milestone

Comments

@pranaykondekar
Copy link

pranaykondekar commented Mar 8, 2024

Skin should demonstrate the usage of the disabled modules...

  • in the docs, add an example for the disabled modules with disabled icon handling
  • add a story for the disabled module with the disabled icon
@LuLaValva LuLaValva added this to the 17.4.0 milestone Mar 26, 2024
@agliga agliga modified the milestones: 17.4.0, 17.5.0 Apr 16, 2024
@agliga
Copy link
Contributor

agliga commented Apr 22, 2024

Can you provide a screenshot for this?
This is actually an invalid issue since you can pass disabled to icon-btn as well and disable it.

For ebayui we need to add disabled attributes to component, but this seems like a skin issue.

@ArtBlue
Copy link
Contributor

ArtBlue commented May 3, 2024

After an internal discussion with Luke, it does look like a styling change is not needed in Skin. However, we do need to add documentation/example and a story to demonstrate the feature. We will be repurposing this issue for that purpose.

@ArtBlue
Copy link
Contributor

ArtBlue commented May 3, 2024

I'm also removing the bug tag as this is not technically a bug, but a missing feature.

@ArtBlue ArtBlue changed the title ebay-calendar ebay-date-textbox: icon color is not honored with disabled textbox ebay-calendar ebay-date-textbox: add docs and story for disabled textbox with disabled icon May 3, 2024
@ArtBlue ArtBlue changed the title ebay-calendar ebay-date-textbox: add docs and story for disabled textbox with disabled icon ebay-calendar, ebay-date-textbox: add docs and story for disabled textbox with disabled icon May 3, 2024
@ArtBlue ArtBlue self-assigned this May 3, 2024
@ArtBlue ArtBlue closed this as completed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants