Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

masonry: add item layout with masonry modifier to skin #2210

Open
6 tasks
megan-woodruff opened this issue Nov 16, 2023 · 0 comments
Open
6 tasks

masonry: add item layout with masonry modifier to skin #2210

megan-woodruff opened this issue Nov 16, 2023 · 0 comments
Assignees

Comments

@megan-woodruff
Copy link

Description

Support masonry layout in Skin. As discussed with team previously, this will likely manifest as a CSS class for item layout with modifiers --grid and --masonry.

Some amount of JS is required to add the CSS styling to adjust the column heights, so there will be a linked Core UI ticket as well.

Screenshots

Screenshot 2023-11-16 at 10 32 39 AM

Figma link

https://www.figma.com/file/zEBdEhbonrBOGzZ0fXzWvM/eBay-Design-System?type=design&node-id=115062%3A162385&mode=dev

Engineering pre-requisites

  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
@megan-woodruff megan-woodruff self-assigned this Nov 16, 2023
@agliga agliga added this to the 17.0.0 milestone Nov 16, 2023
@agliga agliga modified the milestones: 17.0.0, 17.1.0 Dec 21, 2023
@agliga agliga modified the milestones: 17.1.0, 17.2.0 Jan 17, 2024
@ArtBlue ArtBlue modified the milestones: 17.2.0, 17.3.0 Feb 16, 2024
@agliga agliga modified the milestones: 17.3.0, 17.4.0 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants