Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebay-chip: inconsistent property name for delete button aria-label #2018

Open
ianmcburnie opened this issue Nov 9, 2023 · 0 comments
Open

ebay-chip: inconsistent property name for delete button aria-label #2018

ianmcburnie opened this issue Nov 9, 2023 · 0 comments
Assignees
@agliga
Labels
component: chips-combobox type: feature
Milestone
14.0.0

Comments

@ianmcburnie
Copy link
Contributor

Feature Request

Description

We need consistency with our A11Y related property names

Rename a11yDeleteButton to a11yDeleteButtonText.

https://github.com/eBay/ebayui-core/blob/master/src/components/ebay-chip/marko-tag.json#L8
@agliga agliga self-assigned this Apr 29, 2024
@agliga agliga added this to the 13.5.0 milestone Apr 29, 2024
@agliga agliga modified the milestones: 13.5.0, 14.0.0 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agliga agliga

Labels
component: chips-combobox type: feature
Projects
eBayUI
Status: Todo
Milestone
14.0.0
Development

No branches or pull requests
2 participants
@ianmcburnie @agliga