Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EbayFakeMenu: more features #151

Closed
3 tasks done
darkwebdev opened this issue Nov 11, 2022 · 2 comments
Closed
3 tasks done

EbayFakeMenu: more features #151

darkwebdev opened this issue Nov 11, 2022 · 2 comments
Assignees
@darkwebdev
Labels
tech debt The update/fix/change is overdue

Comments

@darkwebdev
Copy link
Collaborator

darkwebdev commented Nov 11, 2022 •
edited

What's not yet supported from Marko version:
EbayFakeMenu Props:
type: Can be "fake"/ "radio" / "checkbox" Marko version ignores it
priority: button priority, "primary" / "secondary" (default) / "none" Marko version ignores it

EbayMenuItem Props:

  • type: Set to "button" for fake menu-item
    checked: whether or not item is checked Marko version ignores it
    value: the value to use with event responses for for the checked array Marko version ignores it
  • badgeNumber: used as the number to be placed in the badge
  • badgeAriaLabel: Yes (only if badge number is provided) | passed as the aria-label directly to the badge
@darkwebdev darkwebdev added the tech debt The update/fix/change is overdue label Nov 11, 2022
@darkwebdev darkwebdev mentioned this issue Nov 11, 2022
Merged
@darkwebdev darkwebdev self-assigned this Nov 15, 2023
@darkwebdev
Copy link
Collaborator Author

Created an issue in skin: eBay/skin#2208
Created an issue in ebayUI marko: eBay/ebayui-core#2024

darkwebdev added a commit that referenced this issue Nov 15, 2023
@darkwebdev
[#151] EbayFakeMenu: support type/badgeNumber/badgeAriaLabel
8d6d8dd
darkwebdev added a commit that referenced this issue Nov 15, 2023
@darkwebdev
[#151] fix types
72009ad
@darkwebdev
Copy link
Collaborator Author

released in 5.9.0

marcial199545 pushed a commit to marcial199545/ebayui-core-react that referenced this issue Dec 13, 2023
@darkwebdev
FEAT: EbayFakeMenu: support type/badgeNumber/badgeAriaLabel (eBay#284)
6bbc9bd 
* [eBay#151] EbayFakeMenu: support type/badgeNumber/badgeAriaLabel

* [eBay#151] fix types

* Add comment about workaround
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkwebdev darkwebdev

Labels
tech debt The update/fix/change is overdue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@darkwebdev