Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::memset #808

Open
prlw1 opened this issue Apr 15, 2024 · 2 comments
Open

std::memset #808

prlw1 opened this issue Apr 15, 2024 · 2 comments
Assignees
@philipianpearce
Labels
enhancement
Milestone
v5.6 pre-release

Comments

@prlw1
Copy link
Contributor

prlw1 commented Apr 15, 2024

Essentially, we #include <cstring> and then use memset rather than std::memset and there isn't a using namespace std.

Admittedly I haven't been able to reproduce the not in scope error someone else reported to me, but given that we are using std11, I think the above makes sense.
@philipianpearce philipianpearce self-assigned this Apr 16, 2024
@philipianpearce
Copy link
Contributor

I agree, I will change code in v5.6.dev to std::memset.

@philipianpearce
Copy link
Contributor

@prlw1 also did you get my comment on #597?

philipianpearce added a commit that referenced this issue Apr 16, 2024
@philipianpearce
Change calls to memset to std::memset - see issue #808
eebd11c
@philipianpearce philipianpearce added this to the v5.6 pre-release milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipianpearce philipianpearce

Labels
enhancement
Projects
None yet
Milestone
v5.6 pre-release
Development

No branches or pull requests
2 participants
@prlw1 @philipianpearce