PHP 8.2 and deprecated static::method() calls for PHP 8.2

[Jimmi08]

Just note because I really don't have idea what I am doing and I needed to rid warnings in my PHP 8.2 local installation

Inspiration in drupal:

• https://wiki.php.net/rfc/deprecate_partially_supported_callables
• https://wiki.php.net/rfc/partially-supported-callables-expand-deprecatio...

"self::method"       -> self::class . "::method"
"parent::method"     -> parent::class . "::method"
"static::method"     -> static::class . "::method"
["self", "method"]   -> [self::class, "method"]
["parent", "method"] -> [parent::class, "method"]
["static", "method"] -> [static::class, "method"]

Used in prepare_request() in e107_class.php
Warnings are away

This worked:

		// Block common bad agents / queries / php issues.
		array_walk($_SERVER,  [self::class, "filter_request"] , '_SERVER');
		if (isset($_GET))
		{
			array_walk($_GET, [self::class, "filter_request"], '_GET');
		}
		if (isset($_POST))
		{
			array_walk($_POST,   [self::class, "filter_request"], '_POST');
			reset($_POST);		// Change of behaviour in PHP 5.3.17?
		}
		if (isset($_COOKIE))
		{
			array_walk($_COOKIE, [self::class, "filter_request"], '_COOKIE');
		}
		if (isset($_REQUEST))
		{
			array_walk($_REQUEST, [self::class, "filter_request"], '_REQUEST');
		}

[Deltik]

Please make a pull request with the fix!

[Jimmi08]

Doesn't it break stuff with older PHP version?

[Deltik]

Should be fine as long as we're not using the first-class callable syntax from PHP 8.1. We're still targeting a minimum PHP version of 5.6.

[Jimmi08]

There is shortened version of array syntax too. Is it not problem?

[Deltik]

Yes, it's fine. The short array syntax was introduced in PHP 5.4.

[Deltik]

#4988, which fixes the deprecation warnings, has been merged!