Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a test for processAttach without the executable #13

Open
cuviper opened this issue Aug 9, 2016 · 1 comment
Open

Need a test for processAttach without the executable #13

cuviper opened this issue Aug 9, 2016 · 1 comment

Comments

@cuviper
Copy link
Contributor

cuviper commented Aug 9, 2016

A regression was found in dyninst/dyninst#146 that attaching to a process without specifying the executable was broken. The documentation for Process::attachProcess does state that the executable is optional. AFAICS this is never tested anywhere.

It's not clear to me the best way to add this. Currently, all tests can run in either create or attach mode. It seems undesirable to add an entire test matrix of attach-no-exe. Is there a good way to write a targeted attach test for this?

@wrwilliams
Copy link
Member

Seems like this should be a variant on the basic proccontrol test (pc_launch)--either we use a custom setup/teardown path, or we add an extra process when pc_launch is running in attach mode. Also, we should most likely change the proccontrol fixtures so that attach defaults to the minimal default, and the extra testing is of attach with arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants