Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in interacting with Chart heatfiled/selection Area and ContextDialog #725

Closed
Sherif-Elhefnawy opened this issue Mar 12, 2020 · 7 comments
Labels
bug A broken behaviour that was working previously needs discussion

Comments

@Sherif-Elhefnawy
Copy link
Contributor

Bug Report

Current Behavior

The following components seem to have different behaviors when it comes to how the user can close them:

Context Dialog
Chart Selection Area
Chart Heatfield

Context Dialog:

  • User is presented with an X button to close it
  • User can click outside the dialog to close it
  • User can press "ESC" on the keyboard to close it

image

Chart Selection Area

  • User is presented with an X button to close it
  • Clicking outside the dialog or chart doesn't close it
  • Pressing "ESC" on the keyboard doesn't close it

image

Chart HeatField

  • User can click on the red bar to close it
  • User is NOT presented with an X button
  • Clicking outside the dialog or chart doesn't close it
  • Pressing "ESC" on the keyboard doesn't close it

image

Summary

Would love to know why are there differences in behavior when it comes to closing the three overlays discussed.

@Sherif-Elhefnawy Sherif-Elhefnawy added the bug A broken behaviour that was working previously label Mar 12, 2020
@ffriedl89
Copy link
Collaborator

I think these are valid questions. I think we can argue that the context dialog is a temporary interaction that should be dismissed once the user wants to interact with anything else on the page.
The selection area has a different use case in addition to the analyze drilldown button - it is also used for filtering data right away. Therefore closing it when interacting with anything else on the page would break the filtering use case.
But the heatfield is a bit problematic for me - and I can't find a good reasoning for the behavior as it is right now.

@dynatrace-oss/ux-core Please help us here 😄

@perihan-rashed
Copy link

@ffriedl89 I already talked to Kathrin Aigner (the component owner), and back then they did not consider the accessibility topic. Therefore, she approved on adding an "x" to the heat-field tooltip.
Regarding closing when clicking outside according to @lukasholzer there is a function that can be used (see attahctment), which would allow us to close when clicking outside. (since we don't have the filtering use-case)
method

@ffriedl89
Copy link
Collaborator

@perihan-rashed thanks for clarifying! So an action item would be to create a ticket to add a closing button also to the heatfield overlay by default :) I will create a separate issue for that and I think we can close this one.

@perihan-rashed
Copy link

@ffriedl89 awesome thank you !

@Sherif-Elhefnawy
Copy link
Contributor Author

Sherif-Elhefnawy commented Mar 12, 2020

And as for the clicking outside? Should that behavior also be in Chart Heatfield and Chart SelectionArea? Or the ESC button? @perihan-rashed

@ffriedl89 ffriedl89 reopened this Mar 12, 2020
@perihan-rashed
Copy link

Confirmed with the component owner and it should close with ESC but not when clicking outside.

@Sherif-Elhefnawy
Copy link
Contributor Author

@ffriedl89 , so let's close this issue and create another issue for the ESC button behavior for both heatField and selectionArea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A broken behaviour that was working previously needs discussion
Projects
None yet
Development

No branches or pull requests

3 participants