Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a toggle event handler for dt-tree-table-toggle-cell #415

Closed
Sherif-Elhefnawy opened this issue Jan 10, 2020 · 3 comments · Fixed by #500
Closed

Provide a toggle event handler for dt-tree-table-toggle-cell #415

Sherif-Elhefnawy opened this issue Jan 10, 2020 · 3 comments · Fixed by #500
Assignees
@gselltho
Labels
feature good first issue Good for newcomers has-pr help wanted Extra attention is needed P2 Issue that is important to resolve as soon as possible
Projects
Barista components

Comments

@Sherif-Elhefnawy
Copy link
Contributor

Feature Request

Summary

Add a toggle event for collapsing or expanding the toggle cell in the dt-tree-table component.

Feature Description

As there is no other way to detect that the toggle cell in the tree table has expanded or collapsed, a click handler on the entire toggle cell was used. But this solution isn't great as a click handler on the toggle icon (toggle event) would be way more precise and avoid weird behavior for the user.
@ffriedl89 ffriedl89 added this to To do in Barista components Jan 13, 2020
@ffriedl89 ffriedl89 added good first issue Good for newcomers help wanted Extra attention is needed P2 Issue that is important to resolve as soon as possible labels Jan 13, 2020
@tomheller
Copy link
Collaborator

@sherifElhefnawyDynatrace to clarify, do you want to have

  1. an event on the dt-tree-table-toggle-cell that notifies you about a change in it's open and close state.
  2. a public function on the dt-tree-table-toggle-cell that will let you programmatically toggle the expanded state?

@Sherif-Elhefnawy
Copy link
Contributor Author

@tomheller , I would like the have the first option where I would get notified about the change of state :)

@gselltho
Copy link
Contributor

Hi @sherifElhefnawyDynatrace,
i'm on it and will do a pull request this week

gselltho added a commit to gselltho/barista that referenced this issue Jan 20, 2020
@gselltho
feat(tree-table): Added events for expansion state changes for DtTree…
d0599fb 
…Table component

Previously there was no way to figure out, if a tree has expanded or collapsed. So expandChanged(bool), expanded(), collapsed() events where introduced. expanded can also be bound with two way binding to set the initial state.

dynatrace-oss#415
gselltho added a commit to gselltho/barista that referenced this issue Jan 20, 2020
@gselltho
feat(tree-table): Added events for expansion state changes for DtTree…
62ea90f 
…Table component

Previously there was no way to figure out, if a tree has expanded or collapsed. So expandChanged(bool), expanded(), collapsed() events where introduced. expanded can also be bound with two way binding to set the initial state.

dynatrace-oss#415
gselltho added a commit to gselltho/barista that referenced this issue Jan 20, 2020
@gselltho
feat(tree-table): Added events for expansion state changes for DtTree…
b779fb9 
…Table.

Previously there was no way to figure out, if a tree has expanded or collapsed.
So `expandChanged(bool)`, `expanded()`, `collapsed()` events where introduced.
Expanded can also be bound with two way binding to set the initial state.

Fixes dynatrace-oss#415
@gselltho gselltho mentioned this issue Jan 20, 2020
Closed
4 tasks
gselltho added a commit to gselltho/barista that referenced this issue Jan 20, 2020
@gselltho
feat(tree-table): Added events for expansion state changes for DtTree…
784ad10 
…Table.

    Previously there was no way to figure out, if a tree has expanded or collapsed.
    So `expandChanged(bool)`, `expanded()`, `collapsed()` events where introduced.
    Expanded can also be bound with two way binding to set the initial state.

    Fixes dynatrace-oss#415
gselltho added a commit to gselltho/barista that referenced this issue Jan 21, 2020
@gselltho
feat(tree-table): Added events for expansion state changes for DtTree…
13800ab 
…Table.

    Previously there was no way to figure out, if a tree has expanded or collapsed.
    So `expandChanged(bool)`, `expanded()`, `collapsed()` events where introduced.
    Expanded can also be bound with two way binding to set the initial state.

    Fixes dynatrace-oss#415
gselltho added a commit to gselltho/barista that referenced this issue Jan 22, 2020
@gselltho
feat(tree-table): Added events for expansion state changes for DtTree…
6a8c0dc 
…Table.

    Previously there was no way to figure out, if a tree has expanded or collapsed.
    So `expandChanged(bool)`, `expanded()`, `collapsed()` events where introduced.
    Expanded can also be bound with two way binding to set the initial state.

    Fixes dynatrace-oss#415
ffriedl89 pushed a commit that referenced this issue Jan 29, 2020
@gselltho @ffriedl89
feat(tree-table): Added events for expansion state changes for DtTree…
d835503 
…Table.

    Previously there was no way to figure out, if a tree has expanded or collapsed.
    So `expandChanged(bool)`, `expanded()`, `collapsed()` events where introduced.
    Expanded can also be bound with two way binding to set the initial state.

    Fixes #415
ffriedl89 pushed a commit that referenced this issue Jan 29, 2020
@gselltho @ffriedl89
feat(tree-table): Added events for expansion state changes for DtTree…
73a77b7 
…TableToggleCell.

    Previously there was no way to figure out, if a tree has expanded or collapsed.
    So `expandChanged(bool)`, `expanded()`, `collapsed()` events where introduced.
    Expanded can also be bound with two way binding to set the initial state.

    Fixes #415
@ffriedl89 ffriedl89 mentioned this issue Jan 29, 2020
Merged
ffriedl89 pushed a commit that referenced this issue Jan 29, 2020
@gselltho @ffriedl89
feat(tree-table): Added events for expansion state changes for DtTree…
e90bf77 
…TableToggleCell.

    Previously there was no way to figure out, if a tree has expanded or collapsed.
    So `expandChanged(bool)`, `expanded()`, `collapsed()` events where introduced.
    Expanded can also be bound with two way binding to set the initial state.

    Fixes #415
ffriedl89 pushed a commit that referenced this issue Jan 29, 2020
@gselltho @ffriedl89
feat(tree-table): Added events for expansion state changes for DtTree…
7b825f6 
…TableToggleCell.

    Previously there was no way to figure out, if a tree has expanded or collapsed.
    So `expandChanged(bool)`, `expanded()`, `collapsed()` events where introduced.
    Expanded can also be bound with two way binding to set the initial state.

    Fixes #415
Barista components automation moved this from To do to Done Jan 30, 2020
ffriedl89 pushed a commit that referenced this issue Jan 30, 2020
@gselltho @ffriedl89
feat(tree-table): Added events for expansion state changes for DtTree…
b4e7e44 
…TableToggleCell.

    Previously there was no way to figure out, if a tree has expanded or collapsed.
    So `expandChanged(bool)`, `expanded()`, `collapsed()` events where introduced.
    Expanded can also be bound with two way binding to set the initial state.

    Fixes #415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gselltho gselltho

Labels
feature good first issue Good for newcomers has-pr help wanted Extra attention is needed P2 Issue that is important to resolve as soon as possible
Projects
No open projects
Barista components
Done
Milestone
No milestone
4 participants
@ffriedl89 @tomheller @gselltho @Sherif-Elhefnawy