Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filter field]: Add information about interaction level on the filter field. #1321

Closed
tomheller opened this issue Jul 20, 2020 · 4 comments
Closed
Labels
feature filter-field Temporary label for filter field issues good first issue Good for newcomers Hacktoberfest 🎃 Issues that might be easy to start with: https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed

Comments

@tomheller
Copy link
Collaborator

Feature Request

Summary

Add an @Output and a property to the filter field that indicates whether the user is currently using the filter field. This will help consumers to determine when it is safe to update filter-definitions (datasource) without crashing the user flow of the user.

The output can be useful to react to changes in the interaction-behaviour, whereas the property can be used for onDemand checks if it is now safe to update the datasource.

This state will probably need to determine the following things:

  • Is the filter field focused
  • is an autocomplete / range currently open

Proposal

Add the following to the filter field.
I'm happy to accept feedback, especially on the naming as I'm not sure how well this naming fits.

@Output() inFlightChange: EventEmitter<FilterFieldInFlightChange<boolean>>
Fires when the user starts interacting with the filter field or stops interacting with it.

inFlight: boolean
Determines if the user is currently interacting with the filter field or not.

Please add your considerations, especially pinging @ffriedl89 @thomaspink @ap-dyna

@tomheller tomheller changed the title Filter field: Add information about interaction level on the filter field. [Filter-field]: Add information about interaction level on the filter field. Jul 20, 2020
@ap-dyna
Copy link

ap-dyna commented Jul 22, 2020

Hi @tomheller,
This description looks good and I see the @output+property combination as useful.
(As for the naming, I will stick to your Barista conventions).

@ffriedl89
Copy link
Collaborator

I can see both the ouput and the boolean property being useful. I am also not quite convinced about the naming tbh.
Maybe
@Output() userInteractionChange for the output
userInteracting or isUserInteracting for the boolean flag

@tomheller
Copy link
Collaborator Author

I think it's a good point to go with
@Output() userInteractionChange for the output.
isUserInteracting for the boolean flag.

@tomheller tomheller added the help wanted Extra attention is needed label Jul 30, 2020
@tomheller tomheller changed the title [Filter-field]: Add information about interaction level on the filter field. [Filter field]: Add information about interaction level on the filter field. Aug 7, 2020
@thomaspink thomaspink added the filter-field Temporary label for filter field issues label Sep 7, 2020
@thomaspink thomaspink added the good first issue Good for newcomers label Sep 24, 2020
@lukasholzer lukasholzer added the Hacktoberfest 🎃 Issues that might be easy to start with: https://hacktoberfest.digitalocean.com/ label Oct 1, 2020
@ffriedl89
Copy link
Collaborator

Moved to internal issue tracking.

rowa-audil added a commit that referenced this issue Dec 17, 2020
This helps to determine when it is safe to update the datasource of the filter field, without breaking the experience of the user.

Fixes #1321

Co-authored-by: Thomas Heller <thomas.heller@dynatrace.com>
rowa-audil added a commit that referenced this issue Dec 18, 2020
This helps to determine when it is safe to update the datasource of the filter field, without breaking the experience of the user.

Fixes #1321

Co-authored-by: Thomas Heller <thomas.heller@dynatrace.com>
ffriedl89 pushed a commit that referenced this issue Dec 18, 2020
This helps to determine when it is safe to update the datasource of the filter field, without breaking the experience of the user.

Fixes #1321

Co-authored-by: Thomas Heller <thomas.heller@dynatrace.com>
github-actions bot pushed a commit that referenced this issue Dec 18, 2020
This helps to determine when it is safe to update the datasource of the filter field, without breaking the experience of the user.

Fixes #1321

Co-authored-by: Thomas Heller <thomas.heller@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature filter-field Temporary label for filter field issues good first issue Good for newcomers Hacktoberfest 🎃 Issues that might be easy to start with: https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants