-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filter field]: Add information about interaction level on the filter field. #1321
Comments
Hi @tomheller, |
I can see both the ouput and the boolean property being useful. I am also not quite convinced about the naming tbh. |
I think it's a good point to go with |
Moved to internal issue tracking. |
This helps to determine when it is safe to update the datasource of the filter field, without breaking the experience of the user. Fixes #1321 Co-authored-by: Thomas Heller <thomas.heller@dynatrace.com>
This helps to determine when it is safe to update the datasource of the filter field, without breaking the experience of the user. Fixes #1321 Co-authored-by: Thomas Heller <thomas.heller@dynatrace.com>
This helps to determine when it is safe to update the datasource of the filter field, without breaking the experience of the user. Fixes #1321 Co-authored-by: Thomas Heller <thomas.heller@dynatrace.com>
This helps to determine when it is safe to update the datasource of the filter field, without breaking the experience of the user. Fixes #1321 Co-authored-by: Thomas Heller <thomas.heller@dynatrace.com>
Feature Request
Summary
Add an
@Output
and a property to the filter field that indicates whether the user is currently using the filter field. This will help consumers to determine when it is safe to update filter-definitions (datasource) without crashing the user flow of the user.The output can be useful to react to changes in the interaction-behaviour, whereas the property can be used for onDemand checks if it is now safe to update the datasource.
This state will probably need to determine the following things:
Proposal
Add the following to the filter field.
I'm happy to accept feedback, especially on the naming as I'm not sure how well this naming fits.
@Output() inFlightChange: EventEmitter<FilterFieldInFlightChange<boolean>>
Fires when the user starts interacting with the filter field or stops interacting with it.
inFlight: boolean
Determines if the user is currently interacting with the filter field or not.
Please add your considerations, especially pinging @ffriedl89 @thomaspink @ap-dyna
The text was updated successfully, but these errors were encountered: