Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick-filter: expose inputChange and currentFilterChanges from filter-field #1025

Closed
christian-fischer opened this issue May 15, 2020 · 4 comments
Assignees
Labels
feature help wanted Extra attention is needed

Comments

@christian-fischer
Copy link
Contributor

Feature Request

Summary

In order to use async/partial options in the filter-field part of quick-filter, I'd like to use the inputChange and currentFilterChanges outputs.

Feature Description

Problem: currently the quick-filter does not expose the inputChange and currentFilterChanges outputs from the filter-field. Therefore no async/partial options are possible. But we would need that in order to do server-side filtering for our async tag loading (there are way too many tags to implement this otherwise in a well scaling manner)

Solution: expose those two events from the filter-field in the quick-filter. We are fine with that those async/partial filters will only show up in the filter-field part of the quick-filter and not in the sidebar.

@lukasholzer
Copy link
Contributor

Hey, thank you very much for filing this feature request!
It is pretty awesome that you are playing around with our experimental quick filter!

Are you willing to contribute this feature to the quick filter? This would be very helpful if you need this issue in the near future.

@tomheller tomheller added the help wanted Extra attention is needed label May 18, 2020
@christian-fischer
Copy link
Contributor Author

Yes, at least it seems like a small change - so I could take care of that.

christian-fischer added a commit to christian-fischer/barista that referenced this issue May 18, 2020
Expose events inputChange and currentFilterChanges.
Fixes dynatrace-oss#1025
@tomheller
Copy link
Collaborator

Yes, at least it seems like a small change - so I could take care of that.

@christian-fischer yes, if you like, please take care of this one. I agree that this should be a fairly small change.

@lukasholzer
Copy link
Contributor

lukasholzer commented May 19, 2020

I think it should be more a proxy of the events to the quick-filter. If you need any help on this edge please DM me!

christian-fischer added a commit to christian-fischer/barista that referenced this issue May 20, 2020
Expose events inputChange and currentFilterChanges.
Fixes dynatrace-oss#1025
christian-fischer added a commit to christian-fischer/barista that referenced this issue May 26, 2020
Expose events inputChange and currentFilterChanges.

Fixes dynatrace-oss#1025
tomheller pushed a commit that referenced this issue May 28, 2020
Expose events inputChange and currentFilterChanges.

Fixes #1025
yngrdyn pushed a commit to yngrdyn/barista that referenced this issue Nov 9, 2020
Expose events inputChange and currentFilterChanges.

Fixes dynatrace-oss#1025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants