Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe tweets to delete on mobile #6

Open
dylano opened this issue Jun 25, 2018 · 2 comments
Open

Swipe tweets to delete on mobile #6

dylano opened this issue Jun 25, 2018 · 2 comments
Labels
enhancement New feature or request React

Comments

@dylano
Copy link
Owner

dylano commented Jun 25, 2018

A swipe left or right should behave just like pressing Remove button

@dylano dylano added the enhancement New feature or request label Jul 21, 2018
@dylano
Copy link
Owner Author

dylano commented Nov 7, 2018

I tried this, on first use I didn't really like it. Reverted to an explicit button instead for now.

Problems were:

  • erroneous swipes dismissing tweets when i didn't mean to. should be solved with looking for a greater X delta
  • needs a nice animation to slide it away. just disappearing from view is jarring

with these fixes it would probably be a nice addition.

@dylano
Copy link
Owner Author

dylano commented Nov 7, 2018

however, swiping doesn't make much sense for the view where you are also displaying the previously Read tweets because you don't want to swipe them away from that view. but then only listening for swipe actions if you are viewing new tweets would be a bit confusing. the explicit button does handle this case well.

@dylano dylano added the React label Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request React
Projects
None yet
Development

No branches or pull requests

1 participant