Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated functions #15

Open
fverdoja opened this issue Jun 6, 2017 · 2 comments
Open

Deprecated functions #15

fverdoja opened this issue Jun 6, 2017 · 2 comments

Comments

@fverdoja
Copy link

fverdoja commented Jun 6, 2017

When running the code I get multiple errors due to the use of deprecated functions.

The function tf.train.SummaryWriter is deprecated, and current installations of Tensorflow don't support it anymore. It should be renamed to tf.summary.FileWriter.

Same thing for:

  • tf.pack, which should be renamed to tf.stack.
  • tf.scalar_summary, which should be renamed to tf.summary.scalar.
  • tf.merge_summary, which should be renamed to tf.summary.merge.

source: https://www.tensorflow.org/install/migration

Also, the order of the arguments of tf.concat is now swapped, so the call in file g_model.py, line 117
inputs = tf.concat(3, [inputs, last_gen_frames])
should be changed to
inputs = tf.concat([inputs, last_gen_frames], 3)

source: tensorflow/tensorflow#7031

If you want I can make a pull request with the changes above.

@fverdoja
Copy link
Author

fverdoja commented Jun 7, 2017

I made the pull request with the fix
(#16)

@dyelax
Copy link
Owner

dyelax commented Jun 8, 2017

Hey @fverdoja, thanks so much for this! I'll check it out this weekend and merge if everything works well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants