Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matter-tools should be a devDependency #5

Open
getkey opened this issue Apr 26, 2019 · 2 comments · May be fixed by #7
Open

matter-tools should be a devDependency #5

getkey opened this issue Apr 26, 2019 · 2 comments · May be fixed by #7

Comments

@getkey
Copy link

getkey commented Apr 26, 2019

Since matter-tools is only used is the demo, it should be a devDependency.

Currently, when the matter-collision-events package is installed it will pull along matter-tools and all its dependencies. This is suboptimal because it results in a bigger node_modules directory and some of matter-tools dependencies take ages to get built cough node-sass cough.

Also, the node-sass that matter-tools uses' build process fails with Node.js 12 at the moment, so matter-collision-events can't be used in a Node.js 12 environment. Of course this issue also needs to be addressed separately, but at least it would not impact matter-collision-events users.

@getkey getkey linked a pull request Jan 23, 2020 that will close this issue
@chazapp
Copy link

chazapp commented Feb 3, 2021

Update on this issue, node-sass still cannot be built on Node 15, and it makes this project unusable. it is because of this dependency tree:

matter-collision-events > matter-tools > dat.gui > sassify > node-sass

matter-tools was updated recently and it updated the dat.gui dependency which should hopefully fix this problem.

@wojciech-skowronek
Copy link

temporary solution

https://classic.yarnpkg.com/en/docs/selective-version-resolutions/:

Add this to your package.json file:

  "resolutions": {
    "matter-tools": "0.14.0",
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants