Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of label colours #52

Open
iteles opened this issue Jan 31, 2017 · 3 comments
Open

Review of label colours #52

iteles opened this issue Jan 31, 2017 · 3 comments
Assignees
Labels
chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! T25m Time Estimate 25 Minutes

Comments

@iteles
Copy link
Member

iteles commented Jan 31, 2017

We need a general review of our label colours.

For example, we have quite a lot of green ones...!
screen shot 2017-01-31 at 12 55 44
screen shot 2017-01-31 at 12 55 49
screen shot 2017-01-31 at 12 55 54
screen shot 2017-01-31 at 12 55 58

@harrygfox (for example 馃槉 Any thoughts)?

@iteles iteles added the help wanted If you can help make progress with this issue, please comment! label Jan 31, 2017
@nelsonic
Copy link
Member

@iteles I don't have an issue with having several green labels.
va-task is the first one I would change to be a totally different color. perhaps even a charcoal, because the label is only designed to be used to trigger the VA-Task Notifier.

please-test also doesn't need to be green, in fact I think it could be an "yellow-ish" color.
similar to the color used for crash-test-dummies:
image

in-progress also does not need to be green. although green is the colour of "go" i.e. motion.
so it kinda "makes sense" for in-progress to be green...

in-review could be any color really ... I'd go with red or purple so it's V. Obvious what the status of the PR is in...

starter#36 is the only (custom) label I think should be green to attract people's attention in a friendly way. but then, if someone has a better suggestion I'm all ears. 馃憤

and help wanted is a GitHub default which I wouldn't change.

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes labels Oct 6, 2021
@nelsonic
Copy link
Member

nelsonic commented Oct 6, 2021

@iteles totally agree that we need to be more semantic with the colors of our labels. 馃挱
(this is probably more than T25m ... 馃)

@nelsonic nelsonic added the chore a tedious but necessary task often paying technical debt label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! T25m Time Estimate 25 Minutes
Projects
None yet
Development

No branches or pull requests

2 participants