Bitwise OR of signed byte value computed

[axkr]

uncommons-maths/core/src/java/main/org/uncommons/maths/binary/BinaryUtils.java

Line 131 in b7ba13a

value |= b;

SpotBug complaints: Byte values are sign extended to 32 bits before any bitwise operations are performed on the value. Thus, if b[0] contains the value 0xff, and x is initially 0, then the code ((x << 8) | b[0]) will sign extend 0xff to get 0xffffffff, and thus give the value 0xffffffff as the result.

Should this be?

value |= (b & 0xff);