Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataSet() initialization of maximum variable #15

Open
Bennyweasl opened this issue Jun 1, 2017 · 0 comments
Open

DataSet() initialization of maximum variable #15

Bennyweasl opened this issue Jun 1, 2017 · 0 comments

Comments

@Bennyweasl
Copy link

When initializing the DataSet class the maximum variable is set to Double.MIN_VALUE. This leads to issues when all values in the dataset are negative.

Recommendations
1.) maximum = -Double.MAX_VALUE
2.) maximum = Double.NEGATIVE_INFINITY

Apache initializes as NAN which can lead to other issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bennyweasl