Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uri-bytestring instead of network-uri? #15

Open
cdupont opened this issue Oct 16, 2020 · 2 comments
Open

Use uri-bytestring instead of network-uri? #15

cdupont opened this issue Oct 16, 2020 · 2 comments

Comments

@cdupont
Copy link

cdupont commented Oct 16, 2020

Using uri-bytestring would be much better for constructing URIs. See for example: haskell-servant/servant#139

https://hackage.haskell.org/package/uri-bytestring-0.1.5/docs/URI-ByteString.html

@dustin
Copy link
Owner

dustin commented Oct 16, 2020

Hey, thanks for the pointer. I hadn't heard of uri-bytestring, but I'll see if it makes my life better or worse. :)

Is there usage of network-uri in here that causes you suffering as a user?

@cdupont
Copy link
Author

cdupont commented Oct 16, 2020

Yeah, I wanted to construct a URI piece by piece using the constructors, and found it quite strange. For example, the port is defined as a String, that should include ":" (e.g. uriPort = ":42"). Not a big deal, just nit-picking :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants