Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make tests" fails #105

Closed
TurtleSnail opened this issue Mar 11, 2024 · 1 comment
Closed

"make tests" fails #105

TurtleSnail opened this issue Mar 11, 2024 · 1 comment
Labels
fix:bug Something isn't working

Comments

@TurtleSnail
Copy link 

root@Dusk-Test:~# cd wallet-core/
root@Dusk-Test:~/wallet-core# git pull
Already up to date.
root@Dusk-Test:~/wallet-core# make test 
warning: unused manifest key: package.respository
warning: the item `Note` is imported redundantly
  --> src/compat/allow.rs:13:20
   |
13 | use phoenix_core::{Note, *};
   |                    ^^^^  - the item `Note` is already imported here
   |
   = note: `#[warn(unused_imports)]` on by default

warning: `dusk-wallet-core` (lib) generated 1 warning
    Finished `release` profile [optimized] target(s) in 0.13s
warning: unused manifest key: package.respository
warning: the item `String` is imported redundantly
   --> src/compat/allow.rs:9:5
    |
9   | use alloc::string::String;
    |     ^^^^^^^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `String` is already defined here
    |
    = note: `#[warn(unused_imports)]` on by default

warning: the item `Note` is imported redundantly
  --> src/compat/allow.rs:13:20
   |
13 | use phoenix_core::{Note, *};
   |                    ^^^^  - the item `Note` is already imported here

warning: the item `Vec` is imported redundantly
   --> src/compat/crypto.rs:11:5
    |
11  | use alloc::vec::Vec;
    |     ^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `Vec` is already defined here

warning: the item `ToString` is imported redundantly
   --> src/compat/mnemonic.rs:15:5
    |
15  | use alloc::string::ToString;
    |     ^^^^^^^^^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `ToString` is already defined here

warning: the item `Vec` is imported redundantly
   --> src/compat/rkyv.rs:18:5
    |
18  | use alloc::vec::Vec;
    |     ^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `Vec` is already defined here

warning: the item `String` is imported redundantly
   --> src/compat/stake.rs:15:5
    |
15  | use alloc::string::String;
    |     ^^^^^^^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `String` is already defined here

warning: the item `Vec` is imported redundantly
   --> src/compat/stake.rs:16:5
    |
16  | use alloc::vec::Vec;
    |     ^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `Vec` is already defined here

warning: the item `String` is imported redundantly
   --> src/compat/tx.rs:16:14
    |
16  |     string::{String, ToString},
    |              ^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `String` is already defined here

warning: the item `ToString` is imported redundantly
   --> src/compat/tx.rs:16:22
    |
16  |     string::{String, ToString},
    |                      ^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `ToString` is already defined here

warning: the item `Vec` is imported redundantly
   --> src/compat/tx.rs:17:5
    |
17  |     vec::Vec,
    |     ^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `Vec` is already defined here

warning: the item `String` is imported redundantly
   --> src/compat/unstake.rs:15:5
    |
15  | use alloc::string::String;
    |     ^^^^^^^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `String` is already defined here

warning: the item `Vec` is imported redundantly
   --> src/compat/unstake.rs:16:5
    |
16  | use alloc::vec::Vec;
    |     ^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `Vec` is already defined here

warning: the item `String` is imported redundantly
   --> src/compat/withdraw.rs:9:5
    |
9   | use alloc::string::String;
    |     ^^^^^^^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `String` is already defined here

warning: the item `Vec` is imported redundantly
   --> src/ffi.rs:9:18
    |
9   | use alloc::{vec, vec::Vec};
    |                  ^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `Vec` is already defined here

warning: the item `String` is imported redundantly
   --> src/tx.rs:9:5
    |
9   | use alloc::string::String;
    |     ^^^^^^^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `String` is already defined here

warning: the item `Vec` is imported redundantly
   --> src/tx.rs:10:5
    |
10  | use alloc::vec::Vec;
    |     ^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `Vec` is already defined here

warning: the item `String` is imported redundantly
   --> src/types.rs:13:5
    |
13  | use alloc::string::String;
    |     ^^^^^^^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `String` is already defined here

warning: the item `Vec` is imported redundantly
   --> src/types.rs:14:5
    |
14  | use alloc::vec::Vec;
    |     ^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `Vec` is already defined here

warning: the item `Vec` is imported redundantly
   --> src/utils.rs:11:5
    |
11  | use alloc::vec::Vec;
    |     ^^^^^^^^^^^^^^^
    |
   ::: /root/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13
    |
125 |     pub use super::v1::*;
    |             --------- the item `Vec` is already defined here

warning: `dusk-wallet-core` (lib) generated 19 warnings
   Compiling dusk-wallet-core v0.21.6 (/root/wallet-core)
warning: `dusk-wallet-core` (lib test) generated 19 warnings (19 duplicates)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 4.90s
     Running unittests src/lib.rs (target/debug/deps/dusk_wallet_core-38b4eac8e4bcdfa6)

running 2 tests
test utils::compose_works ... ok
test utils::knapsack_works ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.13s

     Running tests/wallet.rs (target/debug/deps/wallet-f2dbdf9f44aaf662)

running 8 tests
thread 'execute_works' panicked at library/core/src/panicking.rs:155:5:
unsafe precondition(s) violated: ptr::copy_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread caused non-unwinding panic. aborting.
error: test failed, to rerun pass `--test wallet`

Caused by:
  process didn't exit successfully: `/root/wallet-core/target/debug/deps/wallet-f2dbdf9f44aaf662` (signal: 6, SIGABRT: process abort signal)
make: *** [Makefile:14: test] Error 101
@TurtleSnail TurtleSnail added the fix:bug Something isn't working label Mar 11, 2024
ureeves added a commit that referenced this issue May 7, 2024
@ureeves
Drop wasmer in favor of wasmtime for tests
c5d5bda 
Since we've transitioned to `wasmtime` for the entirety of our stack, we
should also use it for the tests in this crate. This commit does exactly
that, doing away with the `wasmer` dependency, and replacing it with
`wasmtime`.

This also addresses some - if not all - of the problems we've been
having with running the tests. They now pass when compiling them using
`release` compile option. However, they still fail on `debug`.

See-also: #105
@ureeves ureeves mentioned this issue May 7, 2024
Merged
ureeves added a commit that referenced this issue May 7, 2024
@ureeves
Drop wasmer in favor of wasmtime for tests
4c8710c 
Since we've transitioned to `wasmtime` for the entirety of our stack, we
should also use it for the tests in this crate. This commit does exactly
that, doing away with the `wasmer` dependency, and replacing it with
`wasmtime`.

This also also helps in figuring out exactly what's wrong with our test
runs, by eliminating the runtime as a factor - it errors in the same way
in both `debug` and `release` modes.

See-also: #105
@ureeves ureeves mentioned this issue May 8, 2024
Merged
@moCello
Copy link
Member

moCello commented May 13, 2024

Resolved by #112

@moCello moCello closed this as completed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moCello @TurtleSnail