You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
After updating to rust-s3 "0.34.0-rc4" from "0.33" rust-s3 now includes native-tls as a dependency even though I added the "tokio-rustls-tls" feature and disabled the default features.
To Reproduce
Add the following to a empty rust project:
rust-s3 = { version = "0.34.0-rc4", default-features = false, features = ["tokio-rustls-tls"] }
run cargo tree and you should see native-tls included somewhere:
I tried removing the native-tls dependencies but realized that rust-s3 was changed to depend directly on hyper-tls which doesn't seem to support rustls. So I guess fixing this would be a bigger change?
This commit fixes rustls feature being dependant on native-tls and binding to libcrypto.
fixes: durch#369
lucasmerlin
changed the title
Compiling with "tokio-rustls-tls" and default-features = false still compiles depends on native-tls
Compiling with "tokio-rustls-tls" and default-features = false still depends on native-tls
May 10, 2024
Describe the bug
After updating to rust-s3 "0.34.0-rc4" from "0.33" rust-s3 now includes native-tls as a dependency even though I added the "tokio-rustls-tls" feature and disabled the default features.
To Reproduce
Add the following to a empty rust project:
rust-s3 = { version = "0.34.0-rc4", default-features = false, features = ["tokio-rustls-tls"] }
run cargo tree and you should see native-tls included somewhere:
Details
Expected behavior
Native-tls should not be included with the shown configuration.
Environment
1.73
]0.34-rc4
]Additional context
Seems like the problem is the with-tokio feature in rust-s3's Cargo.toml:
The text was updated successfully, but these errors were encountered: