Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#299 introduces a regression that breaks rustls + tokio support #336

Open
ryanswrt opened this issue Apr 10, 2023 · 2 comments
Open

#299 introduces a regression that breaks rustls + tokio support #336

ryanswrt opened this issue Apr 10, 2023 · 2 comments
Assignees
Labels

Comments

@ryanswrt
Copy link

Describe the bug
Previously the with-tokio feature could be used with tokio-rustls-tls - allowing for easy static compilation with musl. After #299 was merged, with-tokio will always pull in native-tls; which forces an openssl dependency

To Reproduce
Upgrade from 0.33.0 to 0.34.0-beta2 with only the with-tokio and tokio-rusttls-tls features enabled, and you will no longer be able to compile with musl

Expected behavior
rusttls to be used

@durch
Copy link
Owner

durch commented Apr 11, 2023

@ryanswrt, good callout, we've remove reqwest, and there is some fallout, it will be cleaned up before the next beta

@lpotthast
Copy link

Ran into the same issue. This is still an issue with the latest beta3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants