Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen restriction on acceptable transports? #217

Open
Stormheg opened this issue Apr 28, 2024 · 0 comments
Open

Loosen restriction on acceptable transports? #217

Stormheg opened this issue Apr 28, 2024 · 0 comments

Comments

@Stormheg
Copy link

Stormheg commented Apr 28, 2024

This package validates and ignores / errors out on transports values that are not members of the AuthenticatorTransport struct. For example, during registration in the parse_registration_credential_json function, unknown transport values are ignored.

In other functions there are explicit checks that fail when confronted with unknown transport values. Like in parse_registration_options_json

The WebAuthn L2 spec (and also the L3 editors draft) mention that Relying Parties SHOULD store the transports from getTransports 1 and warns that modifying or removing items could negatively impact the user experience. 2

It is clear to me that py_webauthn very deliberately ignores this advice and only accepts known values, which has resulted at least two PRs to add support for new transports: #137 and #129

My question: what motivates this deliberate design choice? Why not follow the advice in the spec and allow unknown transports? That would seem more future proof to me.

Footnotes

  1. https://www.w3.org/TR/webauthn-3/#dom-publickeycredentialdescriptor-transports

  2. https://www.w3.org/TR/webauthn-3/#abstract-opdef-credential-record-transports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant