Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you Dockerise this project such that it can run regardless of environment? Thanks #890

Open
jiacheng-0 opened this issue Sep 2, 2021 · 4 comments

Comments

@jiacheng-0
Copy link

Please mention the following:

  • What command was run?
  • Are you working out of a virtualenv environment, Docker, or something else?

sudo apt-get install autoconf automake libtool python3.7-dev python3-tk jq awscli
on Ubuntu 20.04 LTS (WSL)

No virtual env, just installation

@w0rmr1d3r
Copy link
Contributor

Hello @jiacheng-0 ,

It actually exists this -> https://github.com/duo-labs/cloudmapper#using-a-docker-container

Have you checked it out?

Cheers!

@chrisjohnson00
Copy link
Contributor

chrisjohnson00 commented Sep 3, 2021

Hello @jiacheng-0 ,

It actually exists this -> https://github.com/duo-labs/cloudmapper#using-a-docker-container

Have you checked it out?

Cheers!

The container doesn't build... so far here's the errors I've seen:

  • python3.7-dev isn't a package you can install in 3.7-slim by default, there's likely some apt repos that are needed to be added to enable this.

Then there's this:

ERROR: Cannot install -r requirements.txt (line 5) and urllib3==1.26.5 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested urllib3==1.26.5
    botocore 1.17.6 depends on urllib3<1.26 and >=1.20; python_version != "3.4"

So it looks like someone hasn't tested this enough.

After deleting python3.7-dev from the apt install in Dockerfile and removing urllib3==1.26.5 from requirements.txt I'm able to build the container... will edit if I get around to getting it to run (just playing with this tool on a whim)

AFAIK it works with the above changes, I'll PR the changes and you can decide for yourselves.

@w0rmr1d3r
Copy link
Contributor

If it's something regarding conflicts or dependencies in the requirements.txt file, there are a lot of open issues about that.
Check them as well, since this error:

The conflict is caused by:
    The user requested urllib3==1.26.5
    botocore 1.17.6 depends on urllib3<1.26 and >=1.20; python_version != "3.4"

Has already been fixed in other PRs, yet not merged.

@chrisjohnson00
Copy link
Contributor

Has already been fixed in other PRs, yet not merged.

Yes, that's 1 of 2 things I had to fix to get the container to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants