Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frame_color issue #673

Open
ahjstone opened this issue Nov 20, 2019 · 10 comments
Open

frame_color issue #673

ahjstone opened this issue Nov 20, 2019 · 10 comments

Comments

@ahjstone
Copy link

ahjstone commented Nov 20, 2019

~/.config/dunst/dunstrc

[global]
separator_height = 5
separator_color = auto / frame # same result with the 2 options
*** EDIT - correction: separator_color = auto / foreground

When setting a different frame_color in the [global] and [urgency_low/normal/critical] sections, and issuing a series of notifications with:

notify-send [-u low/normal/critical] "123" "ABC"

only the first notification's frames (top, bottom, left, right) are displayed with the correct frame_color.

Once other notifications pop-up, each additional notification is missing the correct top frame_color.

Is this a bug?

  • Version: 1.4.1
  • Install type: package
  • OS: FreeBSD 12.0-RELEASE-p11
@tsipinakis
Copy link
Member

I'm not sure I understand what the issue is here.
Could you post your full dunstrc, what color are you seeing and what are you expecting to see?

@ahjstone
Copy link
Author

(edited a typo in the first post).

I'm expecting each notification to be displayed with its 4 border's dedicated frame_color.

dunstrc.txt (added the txt suffix to upload the file)

separator_color = auto
dunst-notif-auto

separator_color = foreground
dunst-notif-foreground

@tsipinakis
Copy link
Member

I just got some time to test this and now I get what you mean. separator_color = frame will use the color of the topmost notification.

It's not really a bug but a hastily made compromise for code clarity. I'm open to adding an option of using half the separator for the top notification frame color and the other half for the bottom one as I think you expect it do.

@ahjstone
Copy link
Author

How about making it a real separator, like:

|............................................................|
|.................upper notification................|
|............................................................|
|--------------- bottom border --------------|
------------------ separator ------------------
|------------------ top border ----------------|
|.............................................................|
|...................lower notification................|
|.............................................................|

@bynect
Copy link
Member

bynect commented Mar 5, 2024

@fwsmit I noticed some inconsistencies with the frame coloring so I wanted to implement a more well defined behavior

notif-frame_

Where the yellow are the notification frames, the purple is a (optional) "window" frame and red is the separator.

@bynect bynect added this to the v2.0 milestone Mar 5, 2024
@fwsmit
Copy link
Member

fwsmit commented Mar 9, 2024

What is people don't want 3 lines in between every notification? Currently the window frame is hidden in between each notification, showing only the separator

@bynect
Copy link
Member

bynect commented Mar 9, 2024

What is people don't want 3 lines in between every notification? Currently the window frame is hidden in between each notification, showing only the separator

The idea was to be able to control which part of the frame is colored (there was an issue like that). So that you can indeed have no lines or 3 or whatever you like. Something like frames = left,right. But I would start from having a consistent coloring and border because at the moment some lines override each other and cairo is not happy

@fwsmit
Copy link
Member

fwsmit commented Mar 9, 2024

How would you make sure to have a frame at the top and the bottom of all the notifications?

@bynect
Copy link
Member

bynect commented Mar 9, 2024

How would you make sure to have a frame at the top and the bottom of all the notifications?

I won't, the choice is up to the user.

@fwsmit
Copy link
Member

fwsmit commented Mar 9, 2024

Yeah, but how would the user configure this? If you only enable left and right border there would be no top and bottom border.
Edit: I see there is a window border which would work for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants