spec: allow to select rel and media types #54
Conversation
|
This looks great! Definitely meets my use-case and then some. I also like that structured headers is used for this! |
There was a problem hiding this comment.
Looks promising!
One comment comes to mind on both hreflang and type, for both you have:
If this parameter is provided, the server
SHOULDpreload only relations matched by the provided selector
In #46 I was however rather asking for a way to overload the Accept type.
Example for GET /content/objects/{contentId} you can set different Accept and get different representations:
- application/vnd.ez.api.Content+xml
- application/vnd.ez.api.Content+json
- application/vnd.ez.api.ContentInfo+xml
- application/vnd.ez.api.ContentInfo+json
This can furthermore be extended to be able to add more data to the response for instance (custom use cases).
So to enable that I would expect Accept for Preload requests to to be set in the following order:
- If the Preload/Fields header has a type override for the given selector, use this
- If the matched link in the document has a type, use this
- Lastly reuse Accept from the current ("parent") request
Co-authored-by: Grégoire Hébert <gregoire@les-tilleuls.coop>
Co-authored-by: André R. <289757+andrerom@users.noreply.github.com>
Co-authored-by: André R. <289757+andrerom@users.noreply.github.com>
|
@andrerom unfortunately I think that it's fundamentally incompatible with the other goad of this change which is to add selection capabilities similar to what the |
|
In 3e54822 I added a clarification regarding content negotiation: servers should try to guess the best possible value for the |
dunglas
force-pushed
the
spec/hypermedia-selector
branch
from
dda02a0
to
2a587a0
Compare
dunglas
force-pushed
the
spec/hypermedia-selector
branch
from
2a587a0
to
8dc23de
Compare
relparameter@andrerom could you review this change? It should address the eZ Publish's use case (closes #46).
@evert as discussed during API Days Interface, this change to the spec should allow to cover the use cases also covered by your Prefer-Push I-D. Would you mind to take a look?
Thanks!