Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tons of docker tags, little explanation #776

Open
pontus-mp opened this issue May 10, 2024 · 3 comments · Fixed by #781
Open

Tons of docker tags, little explanation #776

pontus-mp opened this issue May 10, 2024 · 3 comments · Fixed by #781
Labels
enhancement New feature or request

Comments

@pontus-mp
Copy link

pontus-mp commented May 10, 2024

Is your feature request related to a problem? Please describe.
The documentation for the docker images points you at https://hub.docker.com/r/dunglas/frankenphp/tags, with... quite a few images (360+ pages worth at time of writing). Figuring out which ones are relevant for you can be a bit tricky, as tons of images has SHA-hashes in their names.

Describe the solution you'd like
Adding some basic instructions for which image to pick would be great, basically something like what's available on https://hub.docker.com/_/php (under Image Variants).
The pattern for packages that are relevant to users seem to be {FrankenPHPVersion}-php{Major.Minor}-{Distro}.

@pontus-mp pontus-mp added the enhancement New feature or request label May 10, 2024
@dunglas
Copy link
Owner

dunglas commented May 10, 2024

This is a "bug". We need to cleanup the SHA tags as they are now uploaded to a specific repository (dunglas/frankenphp-dev).

@pontus-mp
Copy link
Author

Part of it is/was a bug, but adding some short guidance on the summary page about picking a good tag should be useful for new users. Either as detailed as what PHP does, or simply "Use 1-php8.3 unless you have specific needs"

@dunglas
Copy link
Owner

dunglas commented May 15, 2024

@pontus-mp I'm working on fixing the bug (it remains). I already added some more docs: https://github.com/dunglas/frankenphp/pull/781/files#diff-ae5611658dcd443d7a30575bebcdf15a71b7a0f5abebb18b62d00aa0373cae74R5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants