Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make public/ folder configurable via env #765

Open
razvanphp opened this issue May 4, 2024 · 4 comments
Open

Make public/ folder configurable via env #765

razvanphp opened this issue May 4, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@razvanphp
Copy link

Describe you feature request

We tried frankenphp official docker image with Yii2 framework, but our public folder is called web instead of public.

Can we make this configurable via some ENV variable in the official image?

I could probably override it in my own Dockerfile and Caddyfile, but it would be beneficial for other users too.

Thank you for this great piece of software!
R

@razvanphp razvanphp added the enhancement New feature or request label May 4, 2024
@razvanphp
Copy link
Author

Maybe we could change it to root * {$SERVER_ROOT:public/} ?

@dunglas
Copy link
Owner

dunglas commented May 7, 2024

Wouldn't it be better to override the Caddyfile in a custom stage?

@razvanphp
Copy link
Author

Indeed, but it would be nice to have one-liner working with the official docker image for local development.

Should be backwards compatible as the default will still be public/

@dunglas
Copy link
Owner

dunglas commented May 7, 2024

Ok, why not!

Do you want to open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants