fix: SIGPIPE handling with FrankenPHP #550
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dunglas/frankenphp#682.
The extension causes issues with FrankenPHP because it isn't setting the
SA_ONSTACK
signal handler flag, which is mandatory for use in processes started by Go (as well as many other runtimes), and a best practice anyway.PHP itself now uses
SA_ONSTACK
, see this patch for the full rationale: php/php-src#9597Also, the extension uses
signal()
is discouraged:https://www.man7.org/linux/man-pages/man2/signal.2.html
This patch sets
SA_ONSTACK
and switch fromsignal()
tosigaction()
.I didn't change the global behavior, but totally ignoring
SIGPIPE
would also be fine IMHO. Servers should ignore it.