Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected element (date) is not properly identified #129

Open
Gabrielaparada opened this issue May 8, 2024 · 1 comment
Open

Selected element (date) is not properly identified #129

Gabrielaparada opened this issue May 8, 2024 · 1 comment

Comments

@Gabrielaparada
Copy link

The dates have an attribute of 'aria-pressed' which updates to true/false as they are selected/unselected. However, this is not the correct attribute to communicate the selected/unselected date, aria-pressed should only be used for toggle buttons which is not the case in this scenario.

Expected behavior
aria-pressed should be replaced with 'aria-selected'

Screenshot 2024-05-08 at 1 26 43 PM
@WickyNilliams
Copy link
Contributor

aria-selected is not valid on tables. Only on role=grid. We actually started out with that, but grid has its own set of problems.

After discussion with Adrian Roselli, we settled on the current approach. See #26

Do you have any further info on aria-pressed being incorrect?

In any case, this repo is for all intents dead. I no longer have commit access, so any changes are unlikely. I have created a spiritual successor of sorts, [Cally] (https://github.com/WickyNilliams/cally). I'd be happy to continue discussion there if you like, and see what can be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants