Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Bookmark export doesn't truncate file on overwriting #3069

Open
danpla opened this issue Apr 15, 2023 · 1 comment
Open

[Bug] Bookmark export doesn't truncate file on overwriting #3069

danpla opened this issue Apr 15, 2023 · 1 comment

Comments

@danpla
Copy link

danpla commented Apr 15, 2023

Describe the bug

When the bookmarks export overwrites an existing HTML file larger than the exported one, the resulting file is not truncated, that is, it contains trailing data from the original file, and its size stays the same.

How to Reproduce

  1. Add some bookmarks to DDG and export them.
  2. Delete half of the bookmarks and export them again to the same file, confirming overwriting.
  3. Observe the size and contents of the file.

Expected behavior

It should truncate/delete the overwritten file on export.

Environment

- DDG App Version: 5.156
- Device: Armor X7
- OS: Android 10
@satvik2131
Copy link

satvik2131 commented May 6, 2023

Hi , I want to work on the issue and want to ask some questions as well can assign me the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants