Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider (re)exporting all {dplyr} functions (or depending on it) #144

Closed
TimTaylor opened this issue Apr 17, 2024 · 2 comments · Fixed by #163
Closed

Consider (re)exporting all {dplyr} functions (or depending on it) #144

TimTaylor opened this issue Apr 17, 2024 · 2 comments · Fixed by #163

Comments

@TimTaylor
Copy link
Contributor

For consistency with dplyr it would be nice if as_tibble() was available.

Sys.setenv(DUCKPLYR_METHODS_OVERWRITE = FALSE)
library(duckplyr, warn.conflicts = FALSE)
methods_overwrite()
#> ℹ Overwriting dplyr methods with duckplyr methods
as_tibble(mtcars)
#> Error in as_tibble(mtcars): could not find function "as_tibble"
    
methods_restore()
#> ℹ Restoring dplyr methods
library(dplyr, warn.conflicts = FALSE)
as_tibble(mtcars)    
#> # A tibble: 32 × 11
#>      mpg   cyl  disp    hp  drat    wt  qsec    vs    am  gear  carb
#>    <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl> <dbl>
#>  1  21       6  160    110  3.9   2.62  16.5     0     1     4     4
#>  2  21       6  160    110  3.9   2.88  17.0     0     1     4     4
#>  3  22.8     4  108     93  3.85  2.32  18.6     1     1     4     1
#>  4  21.4     6  258    110  3.08  3.22  19.4     1     0     3     1
#>  5  18.7     8  360    175  3.15  3.44  17.0     0     0     3     2
#>  6  18.1     6  225    105  2.76  3.46  20.2     1     0     3     1
#>  7  14.3     8  360    245  3.21  3.57  15.8     0     0     3     4
#>  8  24.4     4  147.    62  3.69  3.19  20       1     0     4     2
#>  9  22.8     4  141.    95  3.92  3.15  22.9     1     0     4     2
#> 10  19.2     6  168.   123  3.92  3.44  18.3     1     0     4     4
#> # ℹ 22 more rows

Created on 2024-04-17 with reprex v2.1.0

@TimTaylor
Copy link
Contributor Author

hmm ... I guess this could actually be a broader issue. It would be nice if {duckplyr} depended on {dplyr} to ensure we have all functions available (e.g. bind_rows). Appreciate it's just one library call away but would still be a "nice to have".

@TimTaylor TimTaylor changed the title Consider (re)exporting as_tibble() Consider (re)exporting all {dplyr} functions (or depending on it) Apr 17, 2024
@krlmlr
Copy link
Collaborator

krlmlr commented May 7, 2024

Thanks, good point. I don't really like "Depends", let's reexport selectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants