Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of required suppress warning annotation #424

Open
mipper opened this issue Feb 23, 2023 · 1 comment
Open

Removal of required suppress warning annotation #424

mipper opened this issue Feb 23, 2023 · 1 comment

Comments

@mipper
Copy link

mipper commented Feb 23, 2023

Describe the bug
It looks like identification of unused @SuppressWarnings may not work correctly when the checkstyle plugin is also being used. The following annotation is removed incorrectly:

    @SuppressWarnings("checkstyle:ModifiedControlVariable")
    public static void method(final StringBuilder escapedValue) {
        for (int i = 0; i < escapedValue.length(); ++i) {
            if (escapedValue.charAt(i) == '"') {
                escapedValue.insert(i++, '"');
            }
        }
    }

I guess SA does't know about checkstyle. Would it be possible to ignore annotations that refer to unknown sources?

Versions
Save Actions: 2.3.0

IntelliJ IDEA 2022.3.2 (Ultimate Edition)
Build #IU-223.8617.56, built on January 26, 2023
Runtime version: 17.0.5+1-b653.25 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Linux 5.19.0-32-generic
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 16
Registry:
debugger.watches.in.variables=false
ide.windowSystem.autoShowProcessPopup=true

Non-Bundled Plugins:
net.sf.opk.avro-schema-support (213.4.0)
com.jetbrains.CyanTheme (1.3)
com.dubreuia (2.3.0)
CheckStyle-IDEA (5.75.0)
MavenRunHelper (4.23.222.2964.0)
GrepConsole (12.15.211.6693.1)
PlantUML integration (5.22.0)

Kotlin: 223-1.8.0-release-345-IJ8617.56
Current Desktop: ubuntu:GNOME

@KnoxasKing
Copy link

As @fishermans said, unfortunately this plugin has been abandoned and therefore is incompatible with new versions of the Jetbrains IDEs.

In alternative you can use this fork:

https://plugins.jetbrains.com/plugin/21538-save-actions-tool
https://github.com/wanghuan9/intellij-plugin-save-action-tool
But for more information check the thread: #427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants