Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large file support #77

Open
tomsmeding opened this issue Mar 22, 2016 · 0 comments
Open

Large file support #77

tomsmeding opened this issue Mar 22, 2016 · 0 comments

Comments

@tomsmeding
Copy link

While reading the source, I noticed that a number of commands, at least head and cat when given a file argument, read in the entire file in memory before doing anything else. This may work fine for small files, but if you want to take the oldest few lines from a HUGE logfile, for example, or when wanting a few bytes from /dev/urandom, this will create a performance problem. Might be related to the cat hangup symptom here. (^C problem might or might not be related?)
I also noticed that a command gets its entire stdin input from the calling function (presumably vorpal); same argument holds.

I've not had the chance to test the actual behaviour of the program as I don't have a desktop nearby at the moment, so sorry for that; but if I'm not mistaken, per-line buffering might be a good idea.

Last but not least: great project, keep up the good work! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant