Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cash not running commands outside of included commands #122

Closed
ItsJamie9494 opened this issue Jan 11, 2020 · 4 comments · May be fixed by #123
Closed

Cash not running commands outside of included commands #122

ItsJamie9494 opened this issue Jan 11, 2020 · 4 comments · May be fixed by #123

Comments

@ItsJamie9494
Copy link

ItsJamie9494 commented Jan 11, 2020 •
edited

cash Will not run a command outside of the included ones. If I try to run, for example, npm, it just shows the help menu. Yet, running echo works just fine, because it's built in.
@ItsJamie9494 ItsJamie9494 changed the title Cash not running commands outside of included commans Cash not running commands outside of included commands Jan 11, 2020
@nfischer
Copy link
Collaborator

Which OS are you using? I believe external commands are still only supported on Windows.

@ItsJamie9494
Copy link
Author

Linux

nfischer added a commit that referenced this issue Jan 14, 2020
@nfischer
feat: allow external commands on unix
146d302 
External commands were previously limited to Windows. There's no good
reason for this, so this adds support for Linux as well.

Fixes #122
Test: manually tried `whoami` and `git status`
Test: manually tried a not-found command, verified output looks good
@nfischer nfischer mentioned this issue Jan 14, 2020
Open
@nfischer
Copy link
Collaborator

#123 just about implements this. I didn't try writing tests yet, just hacked something together.

@ItsJamie9494
Copy link
Author

#123 looks good, I added it onto a local copy of cash I have, and commands like npm are running just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow external commands on unix dthree/cash
2 participants
@nfischer @ItsJamie9494