{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":48062626,"defaultBranch":"master","name":"cockroach","ownerLogin":"dt","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2015-12-15T18:54:23.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/15615?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1717108771.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"438316a18ad86c4b9abe9bc31c57f3100749fcca","ref":"refs/heads/side-eye-dep","pushedAt":"2024-05-30T22:39:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"go.mod: add side-eye sdk\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"go.mod: add side-eye sdk"}},{"before":"3f568c699779e08ec0fdcd23383e969656f398a4","after":"5c09c1a4cdada81ef3ba4b5534d92eb5fbdefe13","ref":"refs/heads/rewrite-span","pushedAt":"2024-05-30T21:14:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"backupccl: add keyRewriter.RewriteSpan\n\nSpan bounds should always be rewritten, even when they fall within the\ntables for which individual keys are elided during a restore, such as the\nliveness table. This elision is typically controlled by the key rewriter\nreturning false for keys in these tables, indicating that they should not\nbe restored. However if it returns false when one of these keys appears as\na span boundary, we still want to rewrite it. Previously when the rewrite of\none of these keys incorrectly returned false, we would return false from\nrewriteSpan. Unfortunately, this early return was done quietly, leaving the\nspan half rewritten.\n\nThis pulls span rewriting into the key rewriter, parameterizing various methods\nto know when they are rewriting span bounds versus keys, so that they only check\nfor and return false for keys in the elided tables when rewriting a key and not\na span.\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"backupccl: add keyRewriter.RewriteSpan"}},{"before":null,"after":"3f568c699779e08ec0fdcd23383e969656f398a4","ref":"refs/heads/rewrite-span","pushedAt":"2024-05-30T17:14:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"backupccl: add keyRewriter.RewriteSpan\n\nSpan bounds should always be rewritten, even when they fall within the\ntables for which individual keys are elided during a restore, such as the\nliveness table. This elision is typically controlled by the key rewriter\nreturning false for keys in these tables, indicating that they should not\nbe restored. However if it returns false when one of these keys appears as\na span boundary, we still want to rewrite it. Previously when the rewrite of\none of these keys incorrectly returned false, we would return false from\nrewriteSpan. Unfortunately, this early return was done quietly, leaving the\nspan half rewritten.\n\nThis pulls span rewriting into the key rewriter, parameterizing various methods\nto know when they are rewriting span bounds versus keys, so that they only check\nfor and return false for keys in the elided tables when rewriting a key and not\na span.\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"backupccl: add keyRewriter.RewriteSpan"}},{"before":"834a56e1d0fc0dcd1daca119c32f41410845b9b6","after":"0e89d1de05e094c5187a5c5c2576585e5ef5e79d","ref":"refs/heads/space","pushedAt":"2024-05-29T12:35:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"server: return encoded errors from DownloadSpan\n\nPreviously DownloadSpan returned its errors in plain strings in its response,\nor as gRPC errors that then were moved into strings in the response by the\nerrorFn in iterateNodes. This, however, meant these errors lost all of their\ntype information.\n\nReturning an error to a gRPC method also does not cause it to be encoded and\ntransported to the caller. Instead, we must encode the error and put the encoded\nerror in a field of the response, as is done for BatchRequest/Response and in\nexecinfrapb's FullError field, in the body of the gRPC method's implementation.\n\nThis is done here for errors returned by the localDownloadSpan section of the\nDownloadSpan RPC implementation, however there are still other error returns\nin this RPC before that call that still use the gRPC error return, as to numerous\nother RPC methods on the status server and similar RPC APIs, so a broader solution\nmay be desired here in the future.\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"server: return encoded errors from DownloadSpan"}},{"before":"1eab0615adfa12d993885af09292ccd4c5945d27","after":"834a56e1d0fc0dcd1daca119c32f41410845b9b6","ref":"refs/heads/space","pushedAt":"2024-05-29T12:05:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"server: return encoded errors from DownloadSpan\n\nPreviously DownloadSpan returned its errors in plain strings in its response,\nor as gRPC errors that then were moved into strings in the response by the\nerrorFn in iterateNodes. This, however, meant these errors lost all of their\ntype information.\n\nReturning an error to a gRPC method also does not cause it to be encoded and\ntransported to the caller. Instead, we must encode the error and put the encoded\nerror in a field of the response, as is done for BatchRequest/Response and in\nexecinfrapb's FullError field, in the body of the gRPC method's implementation.\n\nThis is done here for errors returned by the localDownloadSpan section of the\nDownloadSpan RPC implementation, however there are still other error returns\nin this RPC before that call that still use the gRPC error return, as to numerous\nother RPC methods on the status server and similar RPC APIs, so a broader solution\nmay be desired here in the future.\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"server: return encoded errors from DownloadSpan"}},{"before":"8374da170baec7982e3932526f59f3348825e14c","after":null,"ref":"refs/heads/restore-chunk-worker","pushedAt":"2024-05-28T20:12:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"}},{"before":"8b216edb68544dd59a859c48c817067219a97d01","after":null,"ref":"refs/heads/split-workers","pushedAt":"2024-05-28T20:09:03.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"}},{"before":"42555b0b5e8256d4a08dea76dbd460430a5818a0","after":null,"ref":"refs/heads/cloud-copy-bench","pushedAt":"2024-05-28T17:37:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"}},{"before":"2eb94266d75b8d9a679ef0fa4b346e901ec55c23","after":"8b216edb68544dd59a859c48c817067219a97d01","ref":"refs/heads/split-workers","pushedAt":"2024-05-28T15:05:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"backupccl: bump up restore worker count\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"backupccl: bump up restore worker count"}},{"before":"162863ab2bb8874bbc8edf4971cfd13333edf519","after":"42555b0b5e8256d4a08dea76dbd460430a5818a0","ref":"refs/heads/cloud-copy-bench","pushedAt":"2024-05-28T12:51:28.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"storage: add remote objstorage copy benchmark\n\nThis benchmark's pebble's objstorage.Copy operation when run on top of\ncockroach's gcs and s3 remote storage adaptors.\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"storage: add remote objstorage copy benchmark"}},{"before":null,"after":"162863ab2bb8874bbc8edf4971cfd13333edf519","ref":"refs/heads/cloud-copy-bench","pushedAt":"2024-05-28T12:44:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"storage: add remote objstorage copy benchmark\n\nThis benchmark's pebble's objstorage.Copy operation when run on top of\ncockroach's gcs and s3 remote storage adaptors.\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"storage: add remote objstorage copy benchmark"}},{"before":null,"after":"2eb94266d75b8d9a679ef0fa4b346e901ec55c23","ref":"refs/heads/split-workers","pushedAt":"2024-05-27T19:37:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"backupccl: bump up restore worker count\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"backupccl: bump up restore worker count"}},{"before":"9f35a3be52468ff3e102bf3d0a5491d7bf6a5559","after":null,"ref":"refs/heads/restore-logs","pushedAt":"2024-05-26T11:19:54.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"}},{"before":"b14cd9edbfa15f426739de760bef222df0e82307","after":"9f35a3be52468ff3e102bf3d0a5491d7bf6a5559","ref":"refs/heads/restore-logs","pushedAt":"2024-05-25T22:37:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"kvserver: vinfo expected queue message during online restore\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"kvserver: vinfo expected queue message during online restore"}},{"before":"6dc96996db5be607d6ce1accc1459d0a785fbef5","after":"b14cd9edbfa15f426739de760bef222df0e82307","ref":"refs/heads/restore-logs","pushedAt":"2024-05-25T15:52:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"kvserver: vinfo and pretty print external sst message\n\nPreviously we printed the raw byte synth prefix, which often had unprintable\nchars in it causing log files to be considered binary by some tools.\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"kvserver: vinfo and pretty print external sst message"}},{"before":"563136c6c03b14486fd6af1b5a24566080affe90","after":null,"ref":"refs/heads/backport24.1-123095-123125-123162","pushedAt":"2024-05-25T13:21:41.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"}},{"before":"68c68e1287dfd3031e080c7e97bdcba63cc3ddf4","after":null,"ref":"refs/heads/tpcc-errors","pushedAt":"2024-05-25T13:21:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"}},{"before":"8fb313fc9ab02d4a922f528c389f749330b5774a","after":null,"ref":"refs/heads/restore-span-split","pushedAt":"2024-05-25T13:21:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"}},{"before":"a761dadde1d6dbfb0f31cbc44358307f33fba79c","after":null,"ref":"refs/heads/queue-ext-defaults","pushedAt":"2024-05-25T13:21:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"}},{"before":"091dea4ce343109198ebabd5c09e3fd595035830","after":null,"ref":"refs/heads/drt-hosts","pushedAt":"2024-05-25T13:21:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"}},{"before":null,"after":"1eab0615adfa12d993885af09292ccd4c5945d27","ref":"refs/heads/space","pushedAt":"2024-05-25T13:18:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"backupccl: pause rather than fail download job if disk is full\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"backupccl: pause rather than fail download job if disk is full"}},{"before":null,"after":"6dc96996db5be607d6ce1accc1459d0a785fbef5","ref":"refs/heads/restore-logs","pushedAt":"2024-05-25T12:44:18.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"kvserver: vinfo and pretty print external sst message\n\nPreviously we printed the raw byte synth prefix, which often had unprintable\nchars in it causing log files to be considered binary by some tools.\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"kvserver: vinfo and pretty print external sst message"}},{"before":"01522a27a204364f7ddb05e58566a2120d754ee8","after":"8374da170baec7982e3932526f59f3348825e14c","ref":"refs/heads/restore-chunk-worker","pushedAt":"2024-05-25T12:24:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"backupccl: set running status duing split phase\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"backupccl: set running status duing split phase"}},{"before":null,"after":"b75caa74a617eba45021a692024c9b42e09669eb","ref":"refs/heads/combine-files","pushedAt":"2024-05-24T19:04:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"backupccl: combine adjacent spans in same SST into same virtual file\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"backupccl: combine adjacent spans in same SST into same virtual file"}},{"before":null,"after":"a761dadde1d6dbfb0f31cbc44358307f33fba79c","ref":"refs/heads/queue-ext-defaults","pushedAt":"2024-05-24T11:47:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"kvserver: enable skip of extenral bytes in merge queue\n\nRelease note: none.\nEpic: none","shortMessageHtmlLink":"kvserver: enable skip of extenral bytes in merge queue"}},{"before":"5fffc3e17c8ad12c5b16b9748389b57c7e1c9e02","after":"01522a27a204364f7ddb05e58566a2120d754ee8","ref":"refs/heads/restore-chunk-worker","pushedAt":"2024-05-24T00:54:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"backupccl: remove buffering then flushing in link workers\n\nNow that they don't send splits to the right of their buffer, they can\njust ingest as they go.\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"backupccl: remove buffering then flushing in link workers"}},{"before":"3081d0703b31fc2bbeed2f35a85ac6a7d8c405e9","after":"5fffc3e17c8ad12c5b16b9748389b57c7e1c9e02","ref":"refs/heads/restore-chunk-worker","pushedAt":"2024-05-22T14:12:34.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"backupccl: split chunks in own worker in online restore\n\nPulling the chunk split-and-scatter into its own singleton worker allows\nthat worker to use local state to avoid duplicating the RHS and LHS splits\nof adjacent spans.\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"backupccl: split chunks in own worker in online restore"}},{"before":null,"after":"3081d0703b31fc2bbeed2f35a85ac6a7d8c405e9","ref":"refs/heads/restore-chunk-worker","pushedAt":"2024-05-22T13:47:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"},"commit":{"message":"backupccl: split chunks in own worker in online restore\n\nPulling the chunk split-and-scatter into its own singleton worker allows\nthat worker to use local state to avoid duplicating the RHS and LHS splits\nof adjacent spans.\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"backupccl: split chunks in own worker in online restore"}},{"before":"dbc32906cd1662a2384a96f54f2c2007b9c0da22","after":null,"ref":"refs/heads/traces","pushedAt":"2024-05-22T11:36:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"}},{"before":"f2e6a4b98ad513f5b565b38cfbd2207d9150c3f4","after":null,"ref":"refs/heads/newsplits","pushedAt":"2024-05-22T11:35:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dt","name":"David Taylor","path":"/dt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15615?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWHq3JAA","startCursor":null,"endCursor":null}},"title":"Activity · dt/cockroach"}