Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not sure if I'm clear on how to re-apply updated patch... #520

Open
EdmundsEcho opened this issue Apr 11, 2024 · 0 comments
Open

Not sure if I'm clear on how to re-apply updated patch... #520

EdmundsEcho opened this issue Apr 11, 2024 · 0 comments

Comments

@EdmundsEcho
Copy link

This is a great tool. I really like it. Thank you!

My issue is that I'm not seeing the updated patch without deleting node_modules.

I'm likely a bit confused about what to expect when I apply the patches. I'm in a React dev environment, so using node to serve the app. I have updated patches and can confirm visually that the changes are in the patches directory as expected. However, despite a forced reload of my browser, the updated patch does not show up.

Here is my workflow:

  1. update the source file in node_modules
  2. rebuild the patch with yarn patches/package-name
  3. visually confirm the updates by cat patches/package-name.patch
  4. apply the patch to my project ./node_modules/.bin/patch-package
  5. yarn start

I can also just run yarn install in step 4 because I have the "postinstall": "patch-package" entry in my package.json file.

Either way, I don't see the updated patch in the code loaded into the browser (despite a hard reload).

What works is deleting node_modules and running a fresh install. That workflow is troublesome, but hopefully, I can avoid it while debugging the patch.

Thank you in advance for any pointers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant