Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Reduce patch-package installation size #499

Open
SukkaW opened this issue Oct 31, 2023 · 2 comments
Open

[Proposal] Reduce patch-package installation size #499

SukkaW opened this issue Oct 31, 2023 · 2 comments

Comments

@SukkaW
Copy link

SukkaW commented Oct 31, 2023

The installation size of the patch-package is reaching 2.33 MiB:

image

(https://packagephobia.com/result?p=patch-package)

And here is the current npm dependency graph of the patch-package:

https://npmgraph.js.org/?q=patch-package#zoom=w

image

I am wondering if we can reduce the installation size. And here is what I propose:

Together we can reduce the installation size of the patch-package by 470 KiB.

@ds300 What do you think?

@sesm
Copy link

sesm commented Nov 3, 2023

I thought picocolors was a joke in response to nanocolors drama, but apparently it's now used by the author of nanocolors in his projects (yes, all 3 projects you mentioned above have the same author, so it's just a personal preference, not a statistic).
Anyway, why not colorette? (the project from which nanocolors was originally copied)

@SukkaW
Copy link
Author

SukkaW commented Nov 4, 2023

Anyway, why not colorette? (the project from which nanocolors was originally copied)

The installation size of the colorette (17 KiB) is 3x of picocolors (5.66 KiB) while only 7% faster (https://www.npmjs.com/package/colorette?activeTab=readme#benchmarks). So I'd still prefer picocolors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants