Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some things we can learn from MonkeyType #54

Open
gvanrossum opened this issue Jan 5, 2018 · 3 comments
Open

Some things we can learn from MonkeyType #54

gvanrossum opened this issue Jan 5, 2018 · 3 comments

Comments

@gvanrossum
Copy link
Contributor

Instagram released their competing tool, MonkeyType (blog, docs).

They have more configurability (e.g. type storage, sampling, type rewriting). They use randomization in their profiling hook.

A possibly road to convergence might involve sharing type storage and configuration so you can use either tool to collect types and the other to apply them.

@gvanrossum
Copy link
Contributor Author

gvanrossum commented Jan 5, 2018

MonkeyType's trace hook keeps track separately of the type of values yielded by generators. (I filed #56 separately for this.)

@johnarnold
Copy link

Guido, I've been playing with monkeytype specifically because it supports py3-style annotations. For whatever it's worth, I'd love to see convergence between the two efforts if possible, everyone would benefit. I'd rather contribute to one or the other.

@gvanrossum
Copy link
Contributor Author

I appreciate everybody's desire to only have a single unified tool. But the reality is that Instagram and Dropbox have very different needs and neither has enough resources to spend a lot of time on unification of the tools. That said, whenever I can easily borrow an idea or code from MonkeyType for PyAnnotate I will happily do it, and I expect the same holds for the Instagram folks. You can even help by submitting PRs that help the tools converge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants