Modernize examples #208
Closed
Modernize examples #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 51.40% 51.40%
=======================================
Files 14 14
Lines 1424 1424
=======================================
Hits 732 732
Misses 692 692
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
codecov is acting weird because the integration tests flaked and I re-ran them, the coverage is actually fine. |
|
Hey @greg-db, would it be possible for someone on the team to look at this? I am looking to close my open PRs and this should be ready to merge. |
|
@connorworley Thanks for the note Connor. I'll check in with the team on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big change to get most of our examples building cross-platform. Some Windows-specific constructs around settings have been replaced, and the ASP.NET examples now use ASP.NET Core. Building examples on Linux/macOS/Windows is now part of CI. I've removed the Universal Windows examples from the solution to accomplish this, but their code still lives in the repo.
Also fixes #122.
Checklist
General Contributing
Is This a Code Change?
Validation