Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use “=” in the headers value #64

Open
zzl221000 opened this issue Dec 9, 2021 · 8 comments
Open

use “=” in the headers value #64

zzl221000 opened this issue Dec 9, 2021 · 8 comments

Comments

@zzl221000
Copy link

Using base64 encoded data in the header, webhook does not work.
Because the following code:

                for _, value := range p.Config.Headers {
			header := strings.Split(value, "=")
			req.Header.Set(header[0], header[1])
		}

Maybe it could be changed to strings.SplitN(value, "=", 2)

@DongyunLee
Copy link

I have to use the Cookies header, and the = cannot be parsed too.
For example:

Cookie: key1=value1; key2=value2

I tried to make it run, but i cannot find any solution.

@zzl221000
Copy link
Author

you can try zzl221000/webhook image @DongyunLee

@DongyunLee
Copy link

you can try zzl221000/webhook image @DongyunLee

好嘞,多谢

@DongyunLee
Copy link

you can try zzl221000/webhook image @DongyunLee

If settings are same as drone-webhook?

@zzl221000
Copy link
Author

If settings are same as drone-webhook?

It's a fork. I just fixed "=" bug. This repository seems to be out of maintenance

@DongyunLee
Copy link

If settings are same as drone-webhook?

It's a fork. I just fixed "=" bug. This repository seems to be out of maintenance

多谢,现在能正常发出请求了

@zzl221000
Copy link
Author

@DongyunLee drone k8s 中构建镜像用 drone-kaniko比较方便

@DongyunLee
Copy link

@DongyunLee drone k8s 中构建镜像用 drone-kaniko比较方便

收到,我学习一下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants