Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm basic config with user before any long running validation happens #196

Open
ejm714 opened this issue Jul 1, 2022 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ejm714
Copy link
Collaborator

ejm714 commented Jul 1, 2022

Right now, we check that there are at least some filepaths are valid as part of the TrainConfig validation, which happens before we confirm with the user that the config is correct (when using the CLI).

This is not ideal if you're training on a large number of mounted files (e.g. 100,000), as the filepath check can take around an hour in that case. It would be better if we could surface the config before doing any long running checks, so the user can review and adjust any needed things (e.g. add a cache directory).

@klwetstone klwetstone added enhancement New feature or request good first issue Good for newcomers labels Apr 17, 2024
@aaronphilip19
Copy link

Hey, @sambujangfofana and I are students from the University of Michigan. We are currently working on a project wherein we have to contribute to a Github repository(https://eecs481.org/hw6.html). We are pretty interested in this issue and would want to work on it. We hope to submit a pull request this week. Could we be assigned this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants