Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deon and nbautoexport options #244

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add deon and nbautoexport options #244

wants to merge 23 commits into from

Conversation

ejm714
Copy link

@ejm714 ejm714 commented Mar 5, 2021 •
edited by chrisjkuch

This PR adds options for adding an ethics checklist (deon) and setting up nbuatoexport. A few open questions:

  • should we use a more descriptive name than nbautoexport for the prompt, and if so, what should it be?
  • should the default be yes or no for deon and nbautoexport?

Closes #154
Closes #324

@ejm714 ejm714 requested a review from pjbull March 5, 2021 18:14
@pjbull @jamesmyatt
@drivendata @ericmjalbert @jraviotta @WesRoach @gehbiszumeis @ianepreston @jayqi @inchiosa @r-b-g-b
[WIP] New version with cleaner options (#162)
1fe968d 
* WIP - New version with cleaner options

* Fix find-replace error (#177)

* Remove unnecessary .gitkeep

* Remove unused tox.ini

* Split reqs into dev/non-dev

* Add basic packages support

* Add tests for testing environment creation and requirements

* Set up CI with Azure Pipelines (#194)

* Change archived asciinema example (#163)

* Change archived asciinema example

* Update README.md

Fix Asciinema powerline error

* Update docs to show updated asciinema example

* Added source and destination to Make data target (#169)

* Fix broken Airflow link (#182)

* Fixed: Typo in Makefile (#184)

Fixed typo in Makefile, section "Set up python interpreter environment": intalled --> installed

* Set up CI with Azure Pipelines

[skip ci]

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* str paths for windows support

* handle multiple data providers (#199)

* Add missing env directory bin/activate path

* Remove version from PYTHON_INTERPRETER command

* Search for virtualenvwrapper.sh path if executable not found

* Try chardet for character encoding detection

* Specify python and virtualenv binaries for virtualenvwrapper

* Add shebang to virtualenvwrapper.sh

* Diagnostic

* Try virtualenvwrapper-win

* Set encoding if detected None

* Fixes to Mac and Windows tests on Azure pipelines (#217)

* Temporarily comment out py36

* Update azure-pipelines.yml

* Fix tests on Windows and Mac (#1)

* Temporarily remove py37

* Update virtualenv_harness.sh

* put py37 back in

* Set encoding to utf-8

* Comment out rmvirtualenv

* Update test_creation.py

* Update virtualenv_harness.sh

* Add --show-capture

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* Update test_creation.py

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update Makefile

* Update virtualenv_harness.sh

* Update cookiecutter.json

* Update cookiecutter.json

* Update virtualenv_harness.sh

* Update Makefile

* Update Makefile

* Update Makefile

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update Makefile

* Update Makefile

* Update Makefile

* Update Makefile

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update Makefile

* Update Makefile

* Update virtualenv_harness.sh

* Update Makefile

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update test_creation.py

* Update azure-pipelines.yml

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update virtualenv_harness.sh

* Update cookiecutter.json

* Update conda_harness.sh

* Update conda_harness.sh

* Update conda_harness.sh

Co-authored-by: Eric Jalbert <ericmjalbert@users.noreply.github.com>
Co-authored-by: Jonathan Raviotta <jraviotta@users.noreply.github.com>
Co-authored-by: Wes Roach <wesr000@gmail.com>
Co-authored-by: Christopher Geis <16896724+geisch@users.noreply.github.com>
Co-authored-by: Peter Bull <pjbull@gmail.com>
Co-authored-by: Ian Preston <17241371+ianepreston@users.noreply.github.com>
Co-authored-by: Jay Qi <jayqi@users.noreply.github.com>
Co-authored-by: inchiosa <4316698+inchiosa@users.noreply.github.com>

* More graceful deprecation

* Make tests pass locally

* test version match installed version

* Remove unused imports

* Unremove used import

* Move to GH Actions

* Fix typo

* Test non-windows

* Add netlify configs

* Update suggestion to keep using deprecated cookiecutter template (#231)

* Add mkdocs requirements file to docs directory

* Try setting python version in runtime txt for netlify

* Trigger build

* Python 3.8 netlify

* Python 3.6 netlify

* Do not specify python runtime for netlify

* Use 3.7

This reverts commit 898d7d3.

Co-authored-by: James Myatt <james@jamesmyatt.co.uk>
Co-authored-by: drivendata <info@drivendata.org>
Co-authored-by: Eric Jalbert <ericmjalbert@users.noreply.github.com>
Co-authored-by: Jonathan Raviotta <jraviotta@users.noreply.github.com>
Co-authored-by: Wes Roach <wesr000@gmail.com>
Co-authored-by: Christopher Geis <16896724+geisch@users.noreply.github.com>
Co-authored-by: Ian Preston <17241371+ianepreston@users.noreply.github.com>
Co-authored-by: Jay Qi <jayqi@users.noreply.github.com>
Co-authored-by: inchiosa <4316698+inchiosa@users.noreply.github.com>
Co-authored-by: Robert Gibboni <robert@drivendata.org>
Base automatically changed from new-cli to v2 March 20, 2021 05:38
This was referenced Mar 20, 2021
Merged
Merged
tgrrr and others added 17 commits March 4, 2022 11:57
@tgrrr
docs: add dev-requirements, remove tox.ini (#254)
4cbf452
@pjbull
Formatting
ea0f21a
@pjbull
Docs and test cleanup
4cfe2cb
@pjbull
3.10 specificaiton
ef2e840
@pjbull
Passing tests and lint
a7badf2
@pjbull
testing improvements and hooks refactor
04d0071
@tamara-glazer @pjbull
Lint, format, license (#247)
227eaaf 
* format config files

* make format

* update readme

* no license, py version, update lint format commands

* revert accidental lic removal

Co-authored-by: Peter Bull <pjbull@gmail.com>
@AllenDowney
Updating the Makefile
c3fe711
@AllenDowney
Merge pull request #287 from drivendata/update-makefile
d12f218 
Updating the Makefile
@AllenDowney
Removing deprecation message from v2
fa6c5de
@AllenDowney
Merge pull request #288 from drivendata/remove-deprecation-message
b4c0c12 
Removing deprecation message from v2
@ejm714 @chrisjkuch
add deon option
90a3a68
@ejm714 @chrisjkuch
add nbautoexport option
4d9292b
@ejm714 @chrisjkuch
add expected file
49b8349
@ejm714 @chrisjkuch
add ethics checklist to default files
a86267e
@ejm714 @chrisjkuch
fix missing comma
f9dfbf7
@chrisjkuch
update post_gen_project.py
acc9f7f
@chrisjkuch chrisjkuch self-assigned this Nov 4, 2022
This was linked to issues Nov 4, 2022
Add option to include deon checklist #154
Open
pip 2020 resolver no longer valid #294
Closed
@chrisjkuch
Copy link
Contributor

@pjbull ready for you to take a look!

@chrisjkuch
Copy link
Contributor

We'd like nbautoexport and deon to actually run as packages rather than simply copying over their generated initialization outputs. Options for implementation:

  1. Include them as dependencies of this repo
  2. Have make commands that generate these as a part of the generated template
  3. Current implementation (undesired), generated output from commands is copied in directly

Base automatically changed from v2 to master May 22, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjbull pjbull Awaiting requested review from pjbull

Assignees

@chrisjkuch chrisjkuch

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to include deon checklist pip 2020 resolver no longer valid
6 participants
@ejm714 @chrisjkuch @pjbull @tgrrr @tamara-glazer @AllenDowney