Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RomBanks 0x7 overflowing Byte? #2

Open
maxbit89 opened this issue Jan 13, 2023 · 2 comments
Open

RomBanks 0x7 overflowing Byte? #2

maxbit89 opened this issue Jan 13, 2023 · 2 comments

Comments

@maxbit89
Copy link

maxbit89 commented Jan 13, 2023 •
edited

Hy i looked through the Code and i noticed that in case the ROM Size equals 0x7 you set romBanks to 256 (0x100), since romBanks is from type byte this would overflow.
@drhelius
Copy link
Owner

Nice catch you are completely right, this code is from a looong time ago.

Anyway I don't think there is a cartridge that big (256 Mbit) apart from may be any kind of modern homebrew. I think almost all are under 64Mbit.

@maxbit89
Copy link
Author

Yeah i wasn't even thinking some one would look at this ^^. Just wanted to document in case some one ran into that problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drhelius @maxbit89