Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for unexpected aspect ratio #134

Open
sundowndev opened this issue Feb 28, 2021 · 0 comments
Open

Support for unexpected aspect ratio #134

sundowndev opened this issue Feb 28, 2021 · 0 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@sundowndev
Copy link
Member

sundowndev commented Feb 28, 2021

When uploading a video that has a non 16:9 frame size, one of the encoding jobs fails because of the aspect ratio.

Solution 1

  • Case A: we have a configured frame size of 842x480px. When uploading a video with frame size of 513x1003px, we can scale down to the closest width according to the settings and keep the original aspect ratio. The result is : 245x480px ((513/1003)*480).

  • Case B: we have a rendition with frame size of 1920x1080px. When uploading a video with frame size of 1920x800px, we can keep the original ratio since it's the same width. The result is : 1920x800px.

  • Case C: we have a rendition with frame size of 1280x720px (16:9). When uploading a video with frame size of 1280x1024px (4:3), for each rendition whose width is <= 1280, recalculate the resolution : ((1280/1024)*720) = 900x720px

@sundowndev sundowndev added kind/bug Something isn't working go labels Feb 28, 2021
@sundowndev sundowndev self-assigned this Feb 28, 2021
@sundowndev sundowndev added this to the v0.2.0 milestone Feb 28, 2021
@sundowndev sundowndev added this to To do in v0.x backlog via automation Feb 28, 2021
@sundowndev sundowndev changed the title Support for unexpected frame sizes Support for unexpected aspect ratio Mar 1, 2021
@sundowndev sundowndev mentioned this issue Mar 4, 2021
12 tasks
@sundowndev sundowndev removed the go label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
v0.x backlog
  
To do
Development

No branches or pull requests

1 participant