Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scikit-Learn Compatibility #509

Open
enesgencer18 opened this issue Aug 7, 2023 · 0 comments
Open

Scikit-Learn Compatibility #509

enesgencer18 opened this issue Aug 7, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@enesgencer18
Copy link

Feature request

I would like to include self._estimator_type = 'classifier'.

    def __post_init__(self):
        super(TabNetClassifier, self).__post_init__()
        self._task = 'classification'
        self._default_loss = torch.nn.functional.cross_entropy
        self._default_metric = 'accuracy'
        self._estimator_type = 'classifier'
....

What is the expected behavior?
The expected behavior ensuring better scikit-learn compatibility of the TabNetClassifier() so that TabNetClassifier() can be used in StackingClassifier() or VotingClassifier().

What is motivation or use case for adding/changing the behavior?
Otherwise, we received the following error.

ValueError: The estimator TabNetClassifier should be a classifier.

Are you willing to work on this yourself?
Yes

@enesgencer18 enesgencer18 added the enhancement New feature or request label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants