Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper function for embeddings #249

Open
Optimox opened this issue Dec 13, 2020 · 5 comments
Open

Helper function for embeddings #249

Optimox opened this issue Dec 13, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Optimox
Copy link
Collaborator

Optimox commented Dec 13, 2020

Feature request

As requested by some, and as @ekamioka started on this PR #244. It might be interesting to get some helper functions to use embeddings as it's not the simplest concept in deep learning.

What is the expected behavior?
Calling a few helper function to get all the correct parameters before using TabNet.

What is motivation or use case for adding/changing the behavior?
I think this would make things easier and help a lot of people.

How should this be implemented in your opinion?
Clean and clear, might be available in a helper.py file, completely independent of the rest of the code.

Are you willing to work on this yourself?
Sure why not

@askhan18
Copy link

askhan18 commented Mar 6, 2022

Hey @Optimox, what kind of helper functions are we looking to implement?

@Optimox
Copy link
Collaborator Author

Optimox commented Mar 7, 2022

Hello @askhan18,

Basically the helper functions would facilitate #244.

The very basic would just ask for the categorical column id and would generate the input for tabnet : cat_dims, cat_emb_dims etc...

@Rachit-Gandhi
Copy link

Is this issue still open to work on? Would love to work on this just wanted to understand the progress done

@Optimox
Copy link
Collaborator Author

Optimox commented Jul 20, 2023

Hello @Rachit-Gandhi,

Nothing has been done at the moment, the scope is not well defined.
Basically there are small processing steps needed to correctly use tabnet like defining which columns are categorical and what embedding size should be used for each of those.

The idea would be to propose very simple functions that would make these things easier. Feel free to open a draft PR so that we can discuss potential changes on concrete basis.

@Rachit-Gandhi
Copy link

@Optimox sure, will do it in a week, this project is awesome used in my own project would love to work on this, my current responsibility ends at 5 th August, then I can contribute to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants